Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 1669063002: Add quotes in pnacl install step to avoid shell globing (Closed)

Created:
4 years, 10 months ago by Sam Clegg
Modified:
4 years, 10 months ago
Reviewers:
bradnelson
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/webports.git@master
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Add quotes in pnacl install step to avoid shell globing The globing should be done by the find command rather than the shell. R=bradnelson@chromium.org Committed: https://chromium.googlesource.com/webports/+/e25cdcf9b5b33736a0c82f8a40de751ebc98c9f1

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ports/pnacl/build.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Sam Clegg
Please CQ if LG
4 years, 10 months ago (2016-02-04 22:54:21 UTC) #2
bradnelson
lgtm
4 years, 10 months ago (2016-02-04 22:57:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669063002/1
4 years, 10 months ago (2016-02-04 23:02:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: webports-presubmit on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/webports-presubmit/builds/97)
4 years, 10 months ago (2016-02-04 23:05:46 UTC) #7
Sam Clegg
4 years, 10 months ago (2016-02-04 23:10:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e25cdcf9b5b33736a0c82f8a40de751ebc98c9f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698