Refactoring: Extract git checks in push and merge scripts.

Refactoring: Extract git checks in push and merge scripts.

This extracts the pattern "if call git fails: raise exception", which is spread all over the place. Now all calls to git are required to return gracefully and give a uniform exception message if they don't.

BUG=
R=ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=19494

[Michael Achenbach, 2014-02-19 14:40:22]

PTAL

[ulan, 2014-02-19 14:43:37]

lgtm with a comment

https://codereview.chromium.org/166903012/diff/1/tools/push-to-trunk/common_i...
File tools/push-to-trunk/common_includes.py (right):

https://codereview.chromium.org/166903012/diff/1/tools/push-to-trunk/common_i...
tools/push-to-trunk/common_includes.py:463: except:
This will catch all exceptions. Is that intended? Maybe there is a git specific
exception you can use here.

[Michael Achenbach, 2014-02-19 14:56:05]

https://codereview.chromium.org/166903012/diff/1/tools/push-to-trunk/common_i...
File tools/push-to-trunk/common_includes.py (right):

https://codereview.chromium.org/166903012/diff/1/tools/push-to-trunk/common_i...
tools/push-to-trunk/common_includes.py:463: except:
On 2014/02/19 14:43:37, ulan wrote:
> This will catch all exceptions. Is that intended? Maybe there is a git
specific
> exception you can use here.

Done.

[Michael Achenbach, 2014-02-19 14:56:28]

Committed patchset #2 manually as r19494 (presubmit successful).