Chromium Code Reviews| Index: Source/core/xml/XMLHttpRequest.h |
| diff --git a/Source/core/xml/XMLHttpRequest.h b/Source/core/xml/XMLHttpRequest.h |
| index 6cd13dc0f5f4985c47ec79d02e8e37a176e920a6..8cf83cdcfea2e421fae73d3110783bff0d6c4753 100644 |
| --- a/Source/core/xml/XMLHttpRequest.h |
| +++ b/Source/core/xml/XMLHttpRequest.h |
| @@ -30,6 +30,7 @@ |
| #include "core/loader/ThreadableLoaderClient.h" |
| #include "core/xml/XMLHttpRequestEventTarget.h" |
| #include "core/xml/XMLHttpRequestProgressEventThrottle.h" |
| +#include "heap/Handle.h" |
| #include "platform/AsyncMethodRunner.h" |
| #include "platform/network/FormData.h" |
| #include "platform/network/ResourceResponse.h" |
| @@ -53,11 +54,12 @@ class ThreadableLoader; |
| typedef int ExceptionCode; |
| -class XMLHttpRequest FINAL : public ScriptWrappable, public RefCounted<XMLHttpRequest>, public XMLHttpRequestEventTarget, private ThreadableLoaderClient, public ActiveDOMObject { |
| - WTF_MAKE_FAST_ALLOCATED; |
| - REFCOUNTED_EVENT_TARGET(XMLHttpRequest); |
| +class XMLHttpRequest FINAL : public RefCountedWillBeRefCountedGarbageCollected<XMLHttpRequest>, public ScriptWrappable, public XMLHttpRequestEventTarget, private ThreadableLoaderClient, public ActiveDOMObject { |
|
sof
2014/02/19 12:22:11
Just making a note of it here.. a followup here is
haraken
2014/02/19 12:26:50
Nice catch. I'll move XMLHttpRequestEventTarget an
|
| + WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED; |
| + DECLARE_GC_INFO; |
| + DEFINE_EVENT_TARGET_REFCOUNTING(RefCountedWillBeRefCountedGarbageCollected<XMLHttpRequest>); |
| public: |
| - static PassRefPtr<XMLHttpRequest> create(ExecutionContext*, PassRefPtr<SecurityOrigin> = 0); |
| + static PassRefPtrWillBeRawPtr<XMLHttpRequest> create(ExecutionContext*, PassRefPtr<SecurityOrigin> = 0); |
| virtual ~XMLHttpRequest(); |
| // These exact numeric values are important because JS expects them. |
| @@ -143,6 +145,8 @@ public: |
| DEFINE_ATTRIBUTE_EVENT_LISTENER(readystatechange); |
| + void trace(Visitor*) { } |
| + |
| private: |
| XMLHttpRequest(ExecutionContext*, PassRefPtr<SecurityOrigin>); |