Chromium Code Reviews Chromium Code Reviews
Issue
166903007:
IDL compiler: omit header for WindowMediaSource.idl in Python (Closed)
DescriptionIDL compiler: omit header for WindowMediaSource.idl in Python
WindowMediaSource.idl is an unusual partial interface:
it has no .h header file, since it only consists of constructor attributes.
Python always includes a header, while Perl checks every member to
decide if a header is required.
We were using [LegacyImplementedInBaseClass] to hack around this;
now that it's gone, this adds an extended attribute [NoHeader] to omit
the header.
Once Perl is gone, I think it's clearer to remove [NoHeader] and just
add a stub .h file, so we don't need this special-casing.
(This is easier post-switch b/c it avoids having to hack up Perl.)
See earlier CL:
IDL compiler: avoid include for WindowMediaSource.idl
https://codereview.chromium.org/156573002/
...and:
Remove support for [LegacyImplementedInBaseClass] IDL extended attribute
https://codereview.chromium.org/169273002/
Also:
* Simpler merge logic in interface_dependency_resolver.py
* Remove unneeded test case TestImplements3.idl (only needed for [LegacyImplementedInBaseClass])
BUG=239771
R=haraken
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167510
Patch Set 1 #Patch Set 2 : Revised #Patch Set 3 : Comment #Patch Set 4 : Remove test case #
Messages
Total messages: 29 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
