Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 166903006: Move *ShellWindowLauncher* to *AppWindowLauncher* (Closed)

Created:
6 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Move *ShellWindowLauncher* to *AppWindowLauncher* BUG=344079 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251932

Patch Set 1 #

Total comments: 3

Patch Set 2 : missed a spot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -1039 lines) Patch
A + chrome/browser/ui/ash/launcher/app_window_launcher_controller.h View 4 chunks +11 lines, -14 lines 0 comments Download
A + chrome/browser/ui/ash/launcher/app_window_launcher_controller.cc View 14 chunks +33 lines, -35 lines 0 comments Download
A + chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h View 5 chunks +19 lines, -23 lines 0 comments Download
A + chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc View 14 chunks +27 lines, -31 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 8 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.h View 2 chunks +11 lines, -13 lines 0 comments Download
A + chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.cc View 6 chunks +12 lines, -15 lines 0 comments Download
D chrome/browser/ui/ash/launcher/multi_profile_shell_window_launcher_controller.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/ui/ash/launcher/multi_profile_shell_window_launcher_controller.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/browser/ui/ash/launcher/shell_window_launcher_controller.h View 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc View 1 chunk +0 lines, -231 lines 0 comments Download
D chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.h View 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.cc View 1 chunk +0 lines, -292 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ken Rockot(use gerrit already)
Pretty straightforward change here. This is happening because ShellWindow was renamed to AppWindow.
6 years, 10 months ago (2014-02-18 23:27:58 UTC) #1
Mr4D (OOO till 08-26)
Added a few nits https://codereview.chromium.org/166903006/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h File chrome/browser/ui/ash/launcher/chrome_launcher_controller.h (right): https://codereview.chromium.org/166903006/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h#newcode558 chrome/browser/ui/ash/launcher/chrome_launcher_controller.h:558: // Used to track shell ...
6 years, 10 months ago (2014-02-18 23:37:03 UTC) #2
Ken Rockot(use gerrit already)
https://codereview.chromium.org/166903006/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h File chrome/browser/ui/ash/launcher/chrome_launcher_controller.h (right): https://codereview.chromium.org/166903006/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h#newcode559 chrome/browser/ui/ash/launcher/chrome_launcher_controller.h:559: scoped_ptr<AppWindowLauncherController> shell_window_controller_; On 2014/02/18 23:37:03, Mr4D wrote: > Shouldn't ...
6 years, 10 months ago (2014-02-18 23:51:54 UTC) #3
Mr4D (OOO till 08-26)
lgtm
6 years, 10 months ago (2014-02-18 23:56:28 UTC) #4
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 10 months ago (2014-02-19 00:00:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/166903006/60001
6 years, 10 months ago (2014-02-19 00:04:00 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 02:31:31 UTC) #7
Message was sent while issue was closed. 
Change committed as 251932

Powered by Google App Engine
This is Rietveld 408576698