chromeos/network/onc/onc_validator_unittest.cc - Issue 166903002: Identify and repair ONC files with duplicate GUIDs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_validator_unittest.cc

Issue 166903002: Identify and repair ONC files with duplicate GUIDs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Issue_23567011

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/network/onc/onc_validator.cc ('K') | « chromeos/network/onc/onc_validator.cc ('k') | chromeos/test/data/network/invalid_settings_with_repairs.json » ('j') | chromeos/test/data/network/invalid_settings_with_repairs.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/onc/onc_validator_unittest.cc

diff --git a/chromeos/network/onc/onc_validator_unittest.cc b/chromeos/network/onc/onc_validator_unittest.cc

index 772267678589cfbddfa57de5e740e6e3db292391..6970d87e7f7db8d4c8f7e477e397e38e76900177 100644

--- a/chromeos/network/onc/onc_validator_unittest.cc

+++ b/chromeos/network/onc/onc_validator_unittest.cc

@@ -334,6 +334,16 @@ INSTANTIATE_TEST_CASE_P(

false),

RepairParams("toplevel-repaired",

"toplevel-repaired")),

+ std::make_pair(OncParams("duplicate-network-guid",

+ &kToplevelConfigurationSignature,

+ false),

+ RepairParams("repaired-duplicate-network-guid",

+ "repaired-duplicate-network-guid")),

+ std::make_pair(OncParams("duplicate-cert-id",

pneubeck (no reviews) 2014/02/17 10:11:36 nit: id -> guid

kaliamoorthi 2014/02/17 15:06:49 Done.

+ &kToplevelConfigurationSignature,

+ false),

+ RepairParams("repaired-duplicate-cert-id",

+ "repaired-duplicate-cert-id")),

std::make_pair(OncParams("toplevel-invalid-network",

&kToplevelConfigurationSignature,

true),