Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1669023004: Roll WebRTC 11486:11495, Libjingle 11485:11495 (Closed)

Created:
4 years, 10 months ago by kjellander_chromium
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll WebRTC 11486:11495, Libjingle 11485:11495 Includes changes for moving talk/media to webrtc/media which took place in https://codereview.webrtc.org/1587193006/ WebRTC 11486:11495 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/052f590..e1bbb30 Libjingle 11485:11495 Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/d70be77..abc975d TBR=perkj@chromium.org,sergeyu@chromium.org BUG=webrtc:5420 Committed: https://crrev.com/a4becae24a1347569a22dd5b5f5012ba1b39bcd1 Cr-Commit-Position: refs/heads/master@{#373795}

Patch Set 1 #

Patch Set 2 : Updated GYP and GN for libjingle #

Total comments: 2

Patch Set 3 : Update includes in content and remoting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -149 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder_factory.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_encoder_factory.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_local_audio_track_adapter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_video_capturer_adapter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc_audio_renderer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/chromium_socket_factory.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/webrtc_video_capturer_adapter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/webrtc_video_capturer_adapter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/webrtc_video_renderer_adapter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/test/fake_socket_factory.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/BUILD.gn View 1 4 chunks +54 lines, -54 lines 0 comments Download
M third_party/libjingle/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 5 chunks +72 lines, -72 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
kjellander_chromium
https://codereview.chromium.org/1669023004/diff/20001/third_party/libjingle/BUILD.gn File third_party/libjingle/BUILD.gn (right): https://codereview.chromium.org/1669023004/diff/20001/third_party/libjingle/BUILD.gn#newcode299 third_party/libjingle/BUILD.gn:299: "../webrtc/media/base/audiorenderer.h", This may look ugly but there's plenty of ...
4 years, 10 months ago (2016-02-05 08:12:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669023004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669023004/20001
4 years, 10 months ago (2016-02-05 08:17:04 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/17904) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-05 08:33:35 UTC) #6
Henrik Grunell
lgtm https://codereview.chromium.org/1669023004/diff/20001/third_party/libjingle/BUILD.gn File third_party/libjingle/BUILD.gn (right): https://codereview.chromium.org/1669023004/diff/20001/third_party/libjingle/BUILD.gn#newcode299 third_party/libjingle/BUILD.gn:299: "../webrtc/media/base/audiorenderer.h", On 2016/02/05 08:12:26, kjellander (chromium) wrote: > ...
4 years, 10 months ago (2016-02-05 08:33:35 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669023004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669023004/40001
4 years, 10 months ago (2016-02-05 08:49:31 UTC) #12
kjellander_chromium
+perkj for content/renderer/media TBRing sergeyu for the rest to get this in today.
4 years, 10 months ago (2016-02-05 09:14:53 UTC) #13
Henrik Grunell
lgtm
4 years, 10 months ago (2016-02-05 09:49:15 UTC) #17
perkj_chrome
nice lgtm
4 years, 10 months ago (2016-02-05 09:50:31 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-05 11:04:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669023004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669023004/40001
4 years, 10 months ago (2016-02-05 12:20:55 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-05 12:26:09 UTC) #24
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 12:27:28 UTC) #26
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a4becae24a1347569a22dd5b5f5012ba1b39bcd1
Cr-Commit-Position: refs/heads/master@{#373795}

Powered by Google App Engine
This is Rietveld 408576698