Clean up StoreBuffer::EnsureSpace.

src/store-buffer.h

Index: src/store-buffer.h
diff --git a/src/store-buffer.h b/src/store-buffer.h
index 514534a1ed72c5af95827ffd3926ad90f497e976..c1052fa1a108c9bfce430674d784e2734fae15d4 100644
--- a/src/store-buffer.h
+++ b/src/store-buffer.h
@@ -111,6 +111,7 @@ class StoreBuffer {
   // been promoted.  Rebuilds the store buffer completely if it overflowed.
   void SortUniq();
 
+  bool SpaceAvailable(intptr_t space_needed);

[Michael Starzinger, 2013/06/11 12:23:48]

This helper function should definitely be private, please move it down (e.g. to
where 'Uniq' is declared).

[Hannes Payer (out of office), 2013/06/12 13:14:25]

Done.

   void EnsureSpace(intptr_t space_needed);

[Michael Starzinger, 2013/06/11 12:23:48]

As discussed offline: It would be great to have only one of the two "Compact"
and "EnsureSpace" entry points. There is only one call-site of EnsureSpace left
after this patch, I like that.

[Hannes Payer (out of office), 2013/06/12 13:14:25]

Done.

   void Verify();
 
@@ -160,7 +161,6 @@ class StoreBuffer {
 
   void ClearFilteringHashSets();
 
-  void CheckForFullBuffer();
   void Uniq();
   void ExemptPopularPages(int prime_sample_step, int threshold);
 
@@ -223,7 +223,6 @@ class StoreBufferRebuildScope {
   ~StoreBufferRebuildScope() {
     store_buffer_->callback_ = stored_callback_;
     store_buffer_->store_buffer_rebuilding_enabled_ = stored_state_;
-    store_buffer_->CheckForFullBuffer();
   }
 
  private: