Clean up StoreBuffer::EnsureSpace.

Clean up StoreBuffer::EnsureSpace.

BUG=
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15085

[Michael Starzinger, 2013-06-11 12:23:48]

LGTM with one real comment about the SpaceAvailable method.

https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.cc
File src/store-buffer.cc (left):

https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.cc#oldcod...
src/store-buffer.cc:690: CheckForFullBuffer();
As discussed offline: I am a little bit worried that removing this call will
cause increase in number of store-buffer compactions. But if the impact is not
measurable I am fine with landing it.

https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.h
File src/store-buffer.h (right):

https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.h#newcode114
src/store-buffer.h:114: bool SpaceAvailable(intptr_t space_needed);
This helper function should definitely be private, please move it down (e.g. to
where 'Uniq' is declared).

https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.h#newcode115
src/store-buffer.h:115: void EnsureSpace(intptr_t space_needed);
As discussed offline: It would be great to have only one of the two "Compact"
and "EnsureSpace" entry points. There is only one call-site of EnsureSpace left
after this patch, I like that.

[Hannes Payer (out of office), 2013-06-12 13:14:25]

https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.cc
File src/store-buffer.cc (left):

https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.cc#oldcod...
src/store-buffer.cc:690: CheckForFullBuffer();
On 2013/06/11 12:23:48, Michael Starzinger wrote:
> As discussed offline: I am a little bit worried that removing this call will
> cause increase in number of store-buffer compactions. But if the impact is not
> measurable I am fine with landing it.

I do not think this call makes a lot of sense here and I was not able to measure
any performance impact after removing it.

https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.h
File src/store-buffer.h (right):

https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.h#newcode114
src/store-buffer.h:114: bool SpaceAvailable(intptr_t space_needed);
On 2013/06/11 12:23:48, Michael Starzinger wrote:
> This helper function should definitely be private, please move it down (e.g.
to
> where 'Uniq' is declared).

Done.

https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.h#newcode115
src/store-buffer.h:115: void EnsureSpace(intptr_t space_needed);
On 2013/06/11 12:23:48, Michael Starzinger wrote:
> As discussed offline: It would be great to have only one of the two "Compact"
> and "EnsureSpace" entry points. There is only one call-site of EnsureSpace
left
> after this patch, I like that.

Done.

[Hannes Payer (out of office), 2013-06-12 13:14:41]

Committed patchset #5 manually as r15085 (presubmit successful).