Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: PRESUBMIT.py

Issue 1668963002: Componentize IDR_NET_ERROR_HTML for sharing it with iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 1565 matching lines...) Expand 10 before | Expand all | Expand 10 after
1576 needs to be consumed by WebKit. """ 1576 needs to be consumed by WebKit. """
1577 results = [] 1577 results = []
1578 file_inclusion_pattern = (r".+\.css$",) 1578 file_inclusion_pattern = (r".+\.css$",)
1579 black_list = (_EXCLUDED_PATHS + 1579 black_list = (_EXCLUDED_PATHS +
1580 _TEST_CODE_EXCLUDED_PATHS + 1580 _TEST_CODE_EXCLUDED_PATHS +
1581 input_api.DEFAULT_BLACK_LIST + 1581 input_api.DEFAULT_BLACK_LIST +
1582 (r"^chrome/common/extensions/docs", 1582 (r"^chrome/common/extensions/docs",
1583 r"^chrome/docs", 1583 r"^chrome/docs",
1584 r"^components/dom_distiller/core/css/distilledpage_ios.css", 1584 r"^components/dom_distiller/core/css/distilledpage_ios.css",
1585 r"^components/flags_ui/resources/apple_flags.css", 1585 r"^components/flags_ui/resources/apple_flags.css",
1586 r"^components/neterror/resources/neterror.css",
1586 r"^native_client_sdk")) 1587 r"^native_client_sdk"))
1587 file_filter = lambda f: input_api.FilterSourceFile( 1588 file_filter = lambda f: input_api.FilterSourceFile(
1588 f, white_list=file_inclusion_pattern, black_list=black_list) 1589 f, white_list=file_inclusion_pattern, black_list=black_list)
1589 for fpath in input_api.AffectedFiles(file_filter=file_filter): 1590 for fpath in input_api.AffectedFiles(file_filter=file_filter):
1590 for line_num, line in fpath.ChangedContents(): 1591 for line_num, line in fpath.ChangedContents():
1591 for (deprecated_value, value) in _DEPRECATED_CSS: 1592 for (deprecated_value, value) in _DEPRECATED_CSS:
1592 if deprecated_value in line: 1593 if deprecated_value in line:
1593 results.append(output_api.PresubmitError( 1594 results.append(output_api.PresubmitError(
1594 "%s:%d: Use of deprecated CSS %s, use %s instead" % 1595 "%s:%d: Use of deprecated CSS %s, use %s instead" %
1595 (fpath.LocalPath(), line_num, deprecated_value, value))) 1596 (fpath.LocalPath(), line_num, deprecated_value, value)))
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
1949 results.extend(input_api.canned_checks.CheckTreeIsOpen( 1950 results.extend(input_api.canned_checks.CheckTreeIsOpen(
1950 input_api, 1951 input_api,
1951 output_api, 1952 output_api,
1952 json_url='http://chromium-status.appspot.com/current?format=json')) 1953 json_url='http://chromium-status.appspot.com/current?format=json'))
1953 1954
1954 results.extend(input_api.canned_checks.CheckChangeHasBugField( 1955 results.extend(input_api.canned_checks.CheckChangeHasBugField(
1955 input_api, output_api)) 1956 input_api, output_api))
1956 results.extend(input_api.canned_checks.CheckChangeHasDescription( 1957 results.extend(input_api.canned_checks.CheckChangeHasDescription(
1957 input_api, output_api)) 1958 input_api, output_api))
1958 return results 1959 return results
OLDNEW
« no previous file with comments | « no previous file | chrome/app/theme/default_100_percent/common/error_network_generic.png » ('j') | components/resources/OWNERS » ('J')

Powered by Google App Engine
This is Rietveld 408576698