Componentize IDR_NET_ERROR_HTML for sharing it with iOS.

Componentize IDR_NET_ERROR_HTML for sharing it with iOS.

Componentize IDR_NET_ERROR_HTML and all the dependent resources to
allow sharing them with iOS (this includes IDR_ERROR_NETWORK_GENERIC
and IDR_OMNIBOX_SEARCH_BUTTON_LOUPE).

Copy OWNERS from chrome/renderer/net/ for the new component.

TBR=jochen@chromium.org
BUG=568486
Committed: https://crrev.com/6308d7ff80a50bc5c38aa9e011489e9117abf84d
Cr-Commit-Position: refs/heads/master@{#375432}

[sdefresne, 2016-02-04 19:45:34]

sdefresne@chromium.org changed reviewers:
+ mmenke@chromium.org

[sdefresne, 2016-02-04 19:45:35]

Please take a look.

[sdefresne, 2016-02-08 08:56:56]

sdefresne@chromium.org changed reviewers:
+ rdsmith@chromium.org

[sdefresne, 2016-02-08 08:56:57]

rdsmith would you have more bandwidth to take a look at this?

[Randy Smith (Not in Mondays), 2016-02-08 15:58:43]

rdsmith@chromium.org changed reviewers:
+ ttuttle@chromium.org

[Randy Smith (Not in Mondays), 2016-02-08 15:58:43]

I have some urge to look around for someone else before diving in; I'm feeling a
little low on time at the moment.  Julia, any chance you have time/knowledge to
look at this?

[Randy Smith (Not in Mondays), 2016-02-08 15:59:03]

Description was changed from

==========
Componentize IDR_NET_ERROR_HTML for sharing it with iOS.

Componentize IDR_NET_ERROR_HTML and all the dependent resources to
allow sharing them with iOS (this includes IDR_ERROR_NETWORK_GENERIC
and IDR_OMNIBOX_SEARCH_BUTTON_LOUPE).

Copy OWNERS from chrome/renderer/net/ for the new component.

BUG=568486
==========

to

==========
Componentize IDR_NET_ERROR_HTML for sharing it with iOS.

Componentize IDR_NET_ERROR_HTML and all the dependent resources to
allow sharing them with iOS (this includes IDR_ERROR_NETWORK_GENERIC
and IDR_OMNIBOX_SEARCH_BUTTON_LOUPE).

Copy OWNERS from chrome/renderer/net/ for the new component.

BUG=568486
==========

[Randy Smith (Not in Mondays), 2016-02-08 15:59:03]

rdsmith@chromium.org changed reviewers:
- rdsmith@chromium.org

[sdefresne, 2016-02-08 16:15:36]

On 2016/02/08 at 15:58:43, rdsmith wrote:
> I have some urge to look around for someone else before diving in; I'm feeling
a little low on time at the moment.  Julia, any chance you have time/knowledge
to look at this?

Did you forget to add Julia in the reviewer list?

[Randy Smith (Not in Mondays), 2016-02-08 16:50:21]

On 2016/02/08 16:15:36, sdefresne wrote:
> On 2016/02/08 at 15:58:43, rdsmith wrote:
> > I have some urge to look around for someone else before diving in; I'm
feeling
> a little low on time at the moment.  Julia, any chance you have time/knowledge
> to look at this?
> 
> Did you forget to add Julia in the reviewer list?

Nope, they're there.  "ttuttle@chromium.org"

[sdefresne, 2016-02-09 17:41:01]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2016-02-09 17:41:01]

+droger for a first pass review before OWNERS review

[droger, 2016-02-10 09:31:13]

LGTM

I was wondering if it was worth introducing a separate target for renderer
resources in components (because there is one for chrome resources), but
actually I don't think it's needed.

The renderer already depends on all resources, so the distinction is moot, and
these resources are also used on iOS, which does not have a renderer.

[sdefresne, 2016-02-10 15:54:03]

ttuttle: ping?

[sdefresne, 2016-02-11 22:27:18]

mmenke/ttuttle: could one of you take a look?

I think this is fairly simple CL. I'm just moving some files from
chrome/renderer/resources to components/resources so that they can be shared
with iOS. chrome/renderer already depends on both components/resources and
chrome/resources, so I don't think this bring any bad dependency.

Sorry for being a bit pushy, but this is one of the last change blocking the
unforking of Chrome on iOS. Our team is getting really close to a point where we
can roll chromium instead of merging, and thus if we could land this this week
or at the beginning of next week it would be unblocking us.

The CL may appear large (as the number of file is important), but if you look
closely, it mostly consist of two kinds of changes:

1. moving resources from chrome/renderer/resources to components/resources
2. adding #include of "components/grit/components_resources.h"

This is also directly a followup to the CL componentizing other net errors,
including localized_errors.cc that blundell@ landed recently.

Thank you for you attention and patience.

[mmenke, 2016-02-11 22:38:16]

On 2016/02/11 22:27:18, sdefresne wrote:
> mmenke/ttuttle: could one of you take a look?
> 
> I think this is fairly simple CL. I'm just moving some files from
> chrome/renderer/resources to components/resources so that they can be shared
> with iOS. chrome/renderer already depends on both components/resources and
> chrome/resources, so I don't think this bring any bad dependency.
> 
> Sorry for being a bit pushy, but this is one of the last change blocking the
> unforking of Chrome on iOS. Our team is getting really close to a point where
we
> can roll chromium instead of merging, and thus if we could land this this week
> or at the beginning of next week it would be unblocking us.
> 
> The CL may appear large (as the number of file is important), but if you look
> closely, it mostly consist of two kinds of changes:
> 
> 1. moving resources from chrome/renderer/resources to components/resources
> 2. adding #include of "components/grit/components_resources.h"
> 
> This is also directly a followup to the CL componentizing other net errors,
> including localized_errors.cc that blundell@ landed recently.
> 
> Thank you for you attention and patience.

Sorry I didn't get to this earlier - I didn't get to it last Thursday, was on
bug triage duty Friday and Monday (And given my lack of familiarity with grit,
the review was too big to do while on triage duty), and then you asked Julia, so
I thought I'd let her do it.

I'll get to it today or tomorrow.

[Deprecated (see juliatuttle), 2016-02-11 22:58:56]

Sorry about that, I've been juggling a bunch of stuff.

I can get to this tomorrow if Matt would prefer.

On Thu, Feb 11, 2016, 17:38  <mmenke@chromium.org> wrote:

>
> On 2016/02/11 22:27:18, sdefresne wrote:
> > mmenke/ttuttle: could one of you take a look?
> >
> > I think this is fairly simple CL. I'm just moving some files from
> > chrome/renderer/resources to components/resources so that they can be
shared
> > with iOS. chrome/renderer already depends on both components/resources and
> > chrome/resources, so I don't think this bring any bad dependency.
> >
> > Sorry for being a bit pushy, but this is one of the last change blocking
the
> > unforking of Chrome on iOS. Our team is getting really close to a point
where
> we
> > can roll chromium instead of merging, and thus if we could land this this
week
> > or at the beginning of next week it would be unblocking us.
> >
> > The CL may appear large (as the number of file is important), but if you
look
> > closely, it mostly consist of two kinds of changes:
> >
> > 1. moving resources from chrome/renderer/resources to components/resources
> > 2. adding #include of "components/grit/components_resources.h"
> >
> > This is also directly a followup to the CL componentizing other net errors,
> > including localized_errors.cc that blundell@
>
>  landed recently.
> >
> > Thank you for you attention and patience.
>
> Sorry I didn't get to this earlier - I didn't get to it last Thursday, was on
> bug triage duty Friday and Monday (And given my lack of familiarity with
grit,
> the review was too big to do while on triage duty), and then you asked Julia,
so
> I thought I'd let her do it.
>
> I'll get to it today or tomorrow.
> https://codereview.chromium.org/1668963002/
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mmenke, 2016-02-11 23:02:27]

On 2016/02/11 22:58:56, Julia Tuttle wrote:
> Sorry about that, I've been juggling a bunch of stuff.
> 
> I can get to this tomorrow if Matt would prefer.

I'm happy to take it.  I have not been juggling all that much lately, just been
eager to get my 1-week refactor which has become more like a 1-month refactor
done.

[Deprecated (see juliatuttle), 2016-02-12 16:37:27]

Looking at this now.

[Deprecated (see juliatuttle), 2016-02-12 16:43:05]

lgtm, although I am assuming that someone has checked that all of the rearranged
resources and files still work.

[mmenke, 2016-02-12 16:54:33]

I'll defer to ttuttle.

https://codereview.chromium.org/1668963002/diff/1/components/resources/OWNERS
File components/resources/OWNERS (right):

https://codereview.chromium.org/1668963002/diff/1/components/resources/OWNERS...
components/resources/OWNERS:21: per-file neterror*=jar@chromium.org
Not quite sure why jar was in the other file in the first place, but he's no
longer on the network stack team, so shouldn't add him.

[sdefresne, 2016-02-15 08:45:41]

Description was changed from

==========
Componentize IDR_NET_ERROR_HTML for sharing it with iOS.

Componentize IDR_NET_ERROR_HTML and all the dependent resources to
allow sharing them with iOS (this includes IDR_ERROR_NETWORK_GENERIC
and IDR_OMNIBOX_SEARCH_BUTTON_LOUPE).

Copy OWNERS from chrome/renderer/net/ for the new component.

BUG=568486
==========

to

==========
Componentize IDR_NET_ERROR_HTML for sharing it with iOS.

Componentize IDR_NET_ERROR_HTML and all the dependent resources to
allow sharing them with iOS (this includes IDR_ERROR_NETWORK_GENERIC
and IDR_OMNIBOX_SEARCH_BUTTON_LOUPE).

Copy OWNERS from chrome/renderer/net/ for the new component.

TBR=jochen@chromium.org
BUG=568486
==========

[sdefresne, 2016-02-15 08:46:22]

TBR jochen for moving resources files (lgtm-ed by OWNERS) and trivial changes
(#include, ...).

https://codereview.chromium.org/1668963002/diff/1/components/resources/OWNERS
File components/resources/OWNERS (right):

https://codereview.chromium.org/1668963002/diff/1/components/resources/OWNERS...
components/resources/OWNERS:21: per-file neterror*=jar@chromium.org
On 2016/02/12 at 16:54:33, mmenke wrote:
> Not quite sure why jar was in the other file in the first place, but he's no
longer on the network stack team, so shouldn't add him.

Done.

[sdefresne, 2016-02-15 08:46:26]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-02-15 08:46:26]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
ttuttle@chromium.org
Link to the patchset: https://codereview.chromium.org/1668963002/#ps20001
(title: "Rebase & remove jar@chromium.org from components/resources/OWNERS")

[commit-bot: I haz the power, 2016-02-15 08:46:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1668963002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1668963002/20001

[sdefresne, 2016-02-15 08:47:31]

sdefresne@chromium.org changed reviewers:
+ jochen@chromium.org

[commit-bot: I haz the power, 2016-02-15 09:38:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:49:20]

Description was changed from

==========
Componentize IDR_NET_ERROR_HTML for sharing it with iOS.

Componentize IDR_NET_ERROR_HTML and all the dependent resources to
allow sharing them with iOS (this includes IDR_ERROR_NETWORK_GENERIC
and IDR_OMNIBOX_SEARCH_BUTTON_LOUPE).

Copy OWNERS from chrome/renderer/net/ for the new component.

TBR=jochen@chromium.org
BUG=568486
==========

to

==========
Componentize IDR_NET_ERROR_HTML for sharing it with iOS.

Componentize IDR_NET_ERROR_HTML and all the dependent resources to
allow sharing them with iOS (this includes IDR_ERROR_NETWORK_GENERIC
and IDR_OMNIBOX_SEARCH_BUTTON_LOUPE).

Copy OWNERS from chrome/renderer/net/ for the new component.

TBR=jochen@chromium.org
BUG=568486

Committed: https://crrev.com/6308d7ff80a50bc5c38aa9e011489e9117abf84d
Cr-Commit-Position: refs/heads/master@{#375432}
==========

[commit-bot: I haz the power, 2016-02-16 22:49:21]

Patchset 2 (id:??) landed as
https://crrev.com/6308d7ff80a50bc5c38aa9e011489e9117abf84d
Cr-Commit-Position: refs/heads/master@{#375432}