[turbofan] Validate split-edge form

[turbofan] Validate split-edge form

We assume split-edge form throughout the register allocation pipeline,
so added validation in isel.

BUG=

Committed: https://crrev.com/3dc2635d3bd6b414e172b8572c35e0e1c03da978
Cr-Commit-Position: refs/heads/master@{#33789}

[Mircea Trofin, 2016-02-04 18:42:50]

Description was changed from

==========
[turbofan] Validate split-edge form

We assume split-edge form, so added validation.
BUG=
==========

to

==========
[turbofan] Validate split-edge form

We assume split-edge form, so added validation.

This CL can't go in until we sort out  1665853002, which invalidates
this assumption (or we decide we don't want to assume split-edge
anymore, case in which we'll need to change ResolveControlFlow in
the register allocator pipeline)

BUG=
==========

[Mircea Trofin, 2016-02-04 18:42:51]

mtrofin@chromium.org changed reviewers:
+ bmeurer@chromium.org, jarin@chromium.org

[Benedikt Meurer, 2016-02-05 04:58:06]

Nice. LGTM with nit.

https://codereview.chromium.org/1668953002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/1668953002/diff/1/src/compiler/pipeline.cc#ne...
src/compiler/pipeline.cc:278: sequence_->Validate();
Nit: How about moving this to the end of the InstructionSequence constructor
instead?

[Mircea Trofin, 2016-02-05 16:10:58]

https://codereview.chromium.org/1668953002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/1668953002/diff/1/src/compiler/pipeline.cc#ne...
src/compiler/pipeline.cc:278: sequence_->Validate();
On 2016/02/05 04:58:06, Benedikt Meurer wrote:
> Nit: How about moving this to the end of the InstructionSequence constructor
> instead?

Done.

[Mircea Trofin, 2016-02-05 16:14:12]

The CQ bit was checked by mtrofin@chromium.org

[Mircea Trofin, 2016-02-05 16:14:13]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1668953002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-02-05 16:14:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1668953002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1668953002/20001

[Mircea Trofin, 2016-02-05 16:14:27]

Description was changed from

==========
[turbofan] Validate split-edge form

We assume split-edge form, so added validation.

This CL can't go in until we sort out  1665853002, which invalidates
this assumption (or we decide we don't want to assume split-edge
anymore, case in which we'll need to change ResolveControlFlow in
the register allocator pipeline)

BUG=
==========

to

==========
[turbofan] Validate split-edge form

We assume split-edge form, so added validation.

BUG=
==========

[Mircea Trofin, 2016-02-05 16:15:12]

Description was changed from

==========
[turbofan] Validate split-edge form

We assume split-edge form, so added validation.

BUG=
==========

to

==========
[turbofan] Validate split-edge form

We assume split-edge form throughout the register allocation pipeline, 
so added validation in isel.

BUG=
==========

[commit-bot: I haz the power, 2016-02-05 16:44:33]

Description was changed from

==========
[turbofan] Validate split-edge form

We assume split-edge form throughout the register allocation pipeline, 
so added validation in isel.

BUG=
==========

to

==========
[turbofan] Validate split-edge form

We assume split-edge form throughout the register allocation pipeline, 
so added validation in isel.

BUG=
==========

[commit-bot: I haz the power, 2016-02-05 16:44:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-05 16:44:46]

Description was changed from

==========
[turbofan] Validate split-edge form

We assume split-edge form throughout the register allocation pipeline, 
so added validation in isel.

BUG=
==========

to

==========
[turbofan] Validate split-edge form

We assume split-edge form throughout the register allocation pipeline,
so added validation in isel.

BUG=

Committed: https://crrev.com/3dc2635d3bd6b414e172b8572c35e0e1c03da978
Cr-Commit-Position: refs/heads/master@{#33789}
==========

[commit-bot: I haz the power, 2016-02-05 16:44:47]

Patchset 2 (id:??) landed as
https://crrev.com/3dc2635d3bd6b414e172b8572c35e0e1c03da978
Cr-Commit-Position: refs/heads/master@{#33789}