pkg/compiler/lib/src/cps_ir/gvn.dart - Issue 1668913002: dart2js cps: More aggressive operator specialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/gvn.dart

Issue 1668913002: dart2js cps: More aggressive operator specialization. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Update test expectations Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/gvn.dart

diff --git a/pkg/compiler/lib/src/cps_ir/gvn.dart b/pkg/compiler/lib/src/cps_ir/gvn.dart

index a4a591f3ae2811db3ca1dd12abcc77a5bc15858e..46f5d936ca7e65cf81570ffe4ccaece32f05a88e 100644

--- a/pkg/compiler/lib/src/cps_ir/gvn.dart

+++ b/pkg/compiler/lib/src/cps_ir/gvn.dart

@@ -192,7 +192,7 @@ class GVN extends TrampolineRecursiveVisitor implements Pass {

bool isHoistablePrimitive(Primitive prim) {

if (prim.isSafeForElimination) return true;

- if (prim is NullCheck ||

+ if (prim is ReceiverCheck ||

prim is BoundsCheck ||

prim is GetLength ||

prim is GetField ||