Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: src/objects.h

Issue 1668853002: [proxies] allow duplicate keys for [[OwnPropertyKeys]] trap. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressing nits Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/key-accumulator.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 5a872857bbab22ebeddbbc1a1212d09631803a06..efb174503750781ece47ddb977663eda321c57d4 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1785,6 +1785,7 @@ enum AccessorComponent {
enum GetKeysConversion { KEEP_NUMBERS, CONVERT_TO_STRING };
+enum KeyCollectionType { OWN_ONLY, INCLUDE_PROTOS };
// JSReceiver includes types on which properties can be defined, i.e.,
// JSObject and JSProxy.
@@ -1946,13 +1947,10 @@ class JSReceiver: public HeapObject {
inline static Handle<Smi> GetOrCreateIdentityHash(
Handle<JSReceiver> object);
- enum KeyCollectionType { OWN_ONLY, INCLUDE_PROTOS };
-
// ES6 [[OwnPropertyKeys]] (modulo return type)
MUST_USE_RESULT static MaybeHandle<FixedArray> OwnPropertyKeys(
Handle<JSReceiver> object) {
- return GetKeys(object, JSReceiver::OWN_ONLY, ALL_PROPERTIES,
- CONVERT_TO_STRING);
+ return GetKeys(object, OWN_ONLY, ALL_PROPERTIES, CONVERT_TO_STRING);
}
// Computes the enumerable keys for a JSObject. Used for implementing
« no previous file with comments | « src/key-accumulator.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698