src/json-stringifier.h - Issue 1668853002: [proxies] allow duplicate keys for [[OwnPropertyKeys]] trap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/json-stringifier.h

Issue 1668853002: [proxies] allow duplicate keys for [[OwnPropertyKeys]] trap. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: addressing nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/json-stringifier.h

diff --git a/src/json-stringifier.h b/src/json-stringifier.h

index 5c0459eb1b0aa11bfc6c6125bac53db27aa2cdae..d97ca2ba7374ec0b043bb36200702d3c32033d23 100644

--- a/src/json-stringifier.h

+++ b/src/json-stringifier.h

@@ -567,8 +567,7 @@ BasicJsonStringifier::Result BasicJsonStringifier::SerializeJSObject(

Handle<FixedArray> contents;

ASSIGN_RETURN_ON_EXCEPTION_VALUE(

isolate_, contents,

- JSReceiver::GetKeys(object, JSReceiver::OWN_ONLY, ENUMERABLE_STRINGS),

- EXCEPTION);

+ JSReceiver::GetKeys(object, OWN_ONLY, ENUMERABLE_STRINGS), EXCEPTION);

for (int i = 0; i < contents->length(); i++) {

Object* key = contents->get(i);

« no previous file with comments | « src/debug/debug-scopes.cc ('k') | src/key-accumulator.h » ('j') | no next file with comments »