Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: src/runtime/runtime-forin.cc

Issue 1668853002: [proxies] allow duplicate keys for [[OwnPropertyKeys]] trap. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: enabling test again Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/runtime/runtime-forin.cc
diff --git a/src/runtime/runtime-forin.cc b/src/runtime/runtime-forin.cc
index 57a05f6f3b6a84d48bf0c9cd38d470c54ede9e57..2fa6cbee19fffb875ee48d873342b038c10bab9a 100644
--- a/src/runtime/runtime-forin.cc
+++ b/src/runtime/runtime-forin.cc
@@ -24,8 +24,9 @@ MaybeHandle<HeapObject> Enumerate(Handle<JSReceiver> receiver) {
if (!receiver->IsSimpleEnum()) {
Handle<FixedArray> keys;
ASSIGN_RETURN_ON_EXCEPTION(
- isolate, keys, JSReceiver::GetKeys(receiver, JSReceiver::INCLUDE_PROTOS,
- ENUMERABLE_STRINGS),
+ isolate, keys,
+ JSReceiver::GetKeys(receiver, KeyCollectionType::INCLUDE_PROTOS,
+ ENUMERABLE_STRINGS),
HeapObject);
// Test again, since cache may have been built by GetKeys() calls above.
if (!receiver->IsSimpleEnum()) return keys;

Powered by Google App Engine
This is Rietveld 408576698