Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: src/debug/debug-scopes.cc

Issue 1668853002: [proxies] allow duplicate keys for [[OwnPropertyKeys]] trap. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: enabling test again Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug/debug-scopes.cc
diff --git a/src/debug/debug-scopes.cc b/src/debug/debug-scopes.cc
index d71cccef683e68db8dcb6012a811ded1e604c4c5..0cc7c94c557867d695a5d43b2ee22b87bddad0e3 100644
--- a/src/debug/debug-scopes.cc
+++ b/src/debug/debug-scopes.cc
@@ -476,8 +476,8 @@ MaybeHandle<JSObject> ScopeIterator::MaterializeLocalScope() {
function_context->has_extension() &&
!function_context->IsNativeContext()) {
bool success = CopyContextExtensionToScopeObject(
- handle(function_context->extension_object(), isolate_),
- local_scope, JSReceiver::INCLUDE_PROTOS);
+ handle(function_context->extension_object(), isolate_), local_scope,
+ KeyCollectionType::INCLUDE_PROTOS);
if (!success) return MaybeHandle<JSObject>();
}
@@ -507,7 +507,7 @@ Handle<JSObject> ScopeIterator::MaterializeClosure() {
if (context->has_extension()) {
bool success = CopyContextExtensionToScopeObject(
handle(context->extension_object(), isolate_), closure_scope,
- JSReceiver::OWN_ONLY);
+ KeyCollectionType::OWN_ONLY);
DCHECK(success);
USE(success);
}
@@ -556,7 +556,7 @@ Handle<JSObject> ScopeIterator::MaterializeBlockScope() {
if (context->extension_object() != nullptr) {
bool success = CopyContextExtensionToScopeObject(
handle(context->extension_object()), block_scope,
- JSReceiver::OWN_ONLY);
+ KeyCollectionType::OWN_ONLY);
DCHECK(success);
USE(success);
}
@@ -794,10 +794,9 @@ void ScopeIterator::CopyContextLocalsToScopeObject(
}
}
-
bool ScopeIterator::CopyContextExtensionToScopeObject(
Handle<JSObject> extension, Handle<JSObject> scope_object,
- JSReceiver::KeyCollectionType type) {
+ KeyCollectionType type) {
Handle<FixedArray> keys;
ASSIGN_RETURN_ON_EXCEPTION_VALUE(
isolate_, keys, JSReceiver::GetKeys(extension, type, ENUMERABLE_STRINGS),

Powered by Google App Engine
This is Rietveld 408576698