Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: src/runtime/runtime-array.cc

Issue 1668853002: [proxies] allow duplicate keys for [[OwnPropertyKeys]] trap. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressing nits Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime-forin.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/conversions-inl.h" 8 #include "src/conversions-inl.h"
9 #include "src/elements.h" 9 #include "src/elements.h"
10 #include "src/factory.h" 10 #include "src/factory.h"
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 CONVERT_ARG_HANDLE_CHECKED(JSObject, array, 0); 199 CONVERT_ARG_HANDLE_CHECKED(JSObject, array, 0);
200 CONVERT_NUMBER_CHECKED(uint32_t, length, Uint32, args[1]); 200 CONVERT_NUMBER_CHECKED(uint32_t, length, Uint32, args[1]);
201 201
202 if (!array->elements()->IsDictionary()) { 202 if (!array->elements()->IsDictionary()) {
203 RUNTIME_ASSERT(array->HasFastSmiOrObjectElements() || 203 RUNTIME_ASSERT(array->HasFastSmiOrObjectElements() ||
204 array->HasFastDoubleElements()); 204 array->HasFastDoubleElements());
205 uint32_t actual_length = static_cast<uint32_t>(array->elements()->length()); 205 uint32_t actual_length = static_cast<uint32_t>(array->elements()->length());
206 return *isolate->factory()->NewNumberFromUint(Min(actual_length, length)); 206 return *isolate->factory()->NewNumberFromUint(Min(actual_length, length));
207 } 207 }
208 208
209 KeyAccumulator accumulator(isolate, ALL_PROPERTIES); 209 KeyAccumulator accumulator(isolate, OWN_ONLY, ALL_PROPERTIES);
210 // No need to separate protoype levels since we only get numbers/element keys 210 // No need to separate protoype levels since we only get numbers/element keys
211 for (PrototypeIterator iter(isolate, array, 211 for (PrototypeIterator iter(isolate, array,
212 PrototypeIterator::START_AT_RECEIVER); 212 PrototypeIterator::START_AT_RECEIVER);
213 !iter.IsAtEnd(); iter.Advance()) { 213 !iter.IsAtEnd(); iter.Advance()) {
214 if (PrototypeIterator::GetCurrent(iter)->IsJSProxy() || 214 if (PrototypeIterator::GetCurrent(iter)->IsJSProxy() ||
215 PrototypeIterator::GetCurrent<JSObject>(iter) 215 PrototypeIterator::GetCurrent<JSObject>(iter)
216 ->HasIndexedInterceptor()) { 216 ->HasIndexedInterceptor()) {
217 // Bail out if we find a proxy or interceptor, likely not worth 217 // Bail out if we find a proxy or interceptor, likely not worth
218 // collecting keys in that case. 218 // collecting keys in that case.
219 return *isolate->factory()->NewNumberFromUint(length); 219 return *isolate->factory()->NewNumberFromUint(length);
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 CONVERT_ARG_HANDLE_CHECKED(Object, original_array, 0); 495 CONVERT_ARG_HANDLE_CHECKED(Object, original_array, 0);
496 Handle<Object> constructor; 496 Handle<Object> constructor;
497 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 497 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
498 isolate, constructor, 498 isolate, constructor,
499 Object::ArraySpeciesConstructor(isolate, original_array)); 499 Object::ArraySpeciesConstructor(isolate, original_array));
500 return *constructor; 500 return *constructor;
501 } 501 }
502 502
503 } // namespace internal 503 } // namespace internal
504 } // namespace v8 504 } // namespace v8
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime-forin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698