Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 1668843003: [Interpreter] Removes skips for tests that are no longer crashing with ignition. (Closed)

Created:
4 years, 10 months ago by mythria
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Removes skips for tests that are no longer crashing with ignition. Removes skips for two tests in cctest that are no longer crashing with ignition. BUG=v8:4680 LOG=N Committed: https://crrev.com/a318cb2f5d952a5784e7ac4266acc26ec18e87c8 Cr-Commit-Position: refs/heads/master@{#33732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668843003/1
4 years, 10 months ago (2016-02-04 11:51:25 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 12:15:37 UTC) #4
rmcilroy
Nice, thanks. LGTM.
4 years, 10 months ago (2016-02-04 12:29:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668843003/1
4 years, 10 months ago (2016-02-04 13:19:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 13:35:36 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 13:36:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a318cb2f5d952a5784e7ac4266acc26ec18e87c8
Cr-Commit-Position: refs/heads/master@{#33732}

Powered by Google App Engine
This is Rietveld 408576698