Issue 166883002: Remove HandlerKindField and just encode the handlerkind as the only extra-ic-state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 166883002: Remove HandlerKindField and just encode the handlerkind as the only extra-ic-state. (Closed)

Created:
6 years, 10 months ago by Toon Verwaest

Modified:
6 years, 10 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove HandlerKindField and just encode the handlerkind as the only extra-ic-state. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19385

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -45 lines)			Patch
M	src/a64/ic-a64.cc	View	4 chunks	+4 lines, -7 lines	0 comments	Download
M	src/arm/ic-arm.cc	View	4 chunks	+4 lines, -6 lines	0 comments	Download
M	src/code-stubs.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	src/ic.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+0 lines, -3 lines	1 comment	Download
M	src/objects-inl.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/stub-cache.cc	View	3 chunks	+4 lines, -7 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	4 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with a nit: https://codereview.chromium.org/166883002/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/166883002/diff/1/src/objects.h#newcode5388 src/objects.h:5388: StubType type = NORMAL, Do ...

6 years, 10 months ago (2014-02-14 15:03:40 UTC) #2

Toon Verwaest

6 years, 10 months ago (2014-02-14 15:17:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19385 (presubmit successful).

Expand Messages | Collapse Messages