Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1668803002: depot_tools: add presubmit recipe module (Closed)

Created:
4 years, 10 months ago by Paweł Hajdan Jr.
Modified:
4 years, 10 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

depot_tools: add presubmit recipe module BUG=584197 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
A recipe_modules/presubmit/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
A recipe_modules/presubmit/api.py View 1 chunk +13 lines, -0 lines 0 comments Download
A + recipe_modules/presubmit/example.py View 1 chunk +11 lines, -2 lines 0 comments Download
A + recipe_modules/presubmit/example.expected/basic.json View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Paweł Hajdan Jr.
4 years, 10 months ago (2016-02-04 10:35:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668803002/1
4 years, 10 months ago (2016-02-04 10:35:41 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 10:37:41 UTC) #6
Paweł Hajdan Jr.
+maruel
4 years, 10 months ago (2016-02-04 12:40:19 UTC) #8
rmistry
Pawel asked me to take a look. LGTM
4 years, 10 months ago (2016-02-04 17:34:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668803002/1
4 years, 10 months ago (2016-02-04 17:39:17 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 17:41:34 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298588

Powered by Google App Engine
This is Rietveld 408576698