Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 166873004: Add check for perspective matrix in quickRejectY (Closed)

Created:
6 years, 10 months ago by robertphillips
Modified:
6 years, 10 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

When the CTM has perspective the back-project method in quickRejectY goes haywire. Committed: http://code.google.com/p/skia/source/detail?r=13460

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address code review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M include/core/SkCanvas.h View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
6 years, 10 months ago (2014-02-14 17:35:01 UTC) #1
reed1
I fear the perf-hit of making a function call (getTotalMatrix), but that could be address ...
6 years, 10 months ago (2014-02-14 17:45:18 UTC) #2
robertphillips
I have created a bug for the follow on actions (Issue 2179 Quick rejecting text ...
6 years, 10 months ago (2014-02-14 18:32:40 UTC) #3
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 10 months ago (2014-02-14 18:57:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/166873004/60001
6 years, 10 months ago (2014-02-14 18:57:37 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 19:52:20 UTC) #6
Message was sent while issue was closed.
Change committed as 13460

Powered by Google App Engine
This is Rietveld 408576698