Add additional properties to display system info on ChromeOS

chrome/common/extensions/api/system_info_display.idl

Index: chrome/common/extensions/api/system_info_display.idl
diff --git a/chrome/common/extensions/api/system_info_display.idl b/chrome/common/extensions/api/system_info_display.idl
index e6462371da48cb19560ccbbceccd4672e649cf3e..c0166e591678b7acdda25712148ca3addee8231e 100644
--- a/chrome/common/extensions/api/system_info_display.idl
+++ b/chrome/common/extensions/api/system_info_display.idl
@@ -20,6 +20,11 @@ namespace systemInfo.display {
     DOMString id;
     // The user-friendly name (e.g. "HP LCD monitor").
     DOMString name;
+    // Identifier of the display that is being mirrored on the display unit.
+    // If mirroring is not in progress, set to an empty string.

[asargent_no_longer_on_chrome, 2013/06/11 18:22:01]

You could also make the field optional (just add a question mark after the type
name), and then it would be undefined if mirroring is not in progress. I think
the code people would write would be the same either way, e.g.

chrome.systemInfo.display.getDisplayInfo(function(info) {
  if (info.mirroringSourceId) {
    // do something, etc.
    ...
  }
  ...
});

so feel free to leave it as you currently have if you want.

[tbarzic, 2013/06/11 23:56:53]

ok, I'll leave it as it is then

+    // Currently exposed only on ChromeOS. Will be set to an empty string on
+    // other platforms.
+    DOMString mirroringSourceId;
     // True if this is the primary display.
     boolean isPrimary;
     // True if this is an internal display.
@@ -30,9 +35,20 @@ namespace systemInfo.display {
     double dpiX;
     // The number of pixels per inch along the y-axis.
     double dpiY;
-    // The bounds of the display.
+    // The display's clockwise rotation in degrees relative to the vertical
+    // position.
+    // Currently exposed only on ChromeOS. Will be set to 0 on other platforms.
+    long rotation;
+    // The display's logical bounds. The logical coordinates are given relative
+    // to the primary display.
     Bounds bounds;
-    // The usable work area of the display.
+    // The display's bounds in the screen's coordinate system.
+    // Currently exposed only on ChromeOS. Will be set to empty bounds on
+    // other platforms.
+    Bounds visibleArea;
+    // The usable work area of the display within the display bounds. The work
+    // area excludes areas of the display reserved for OS, for example taskbar
+    // and launcher.
     Bounds workArea;

[asargent_no_longer_on_chrome, 2013/06/11 18:22:01]

style nit: it would be a little easier to read these if you introduced a leading
newline above each starting comment block, e.g.

// Whatever
long foo;

// Something
DOMString bar;

[tbarzic, 2013/06/11 23:56:53]

Done.

   };