Add additional properties to display system info on ChromeOS

chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "base/command_line.h"
 #include "base/message_loop.h"
+#include "base/strings/string_number_conversions.h"
 #include "chrome/browser/extensions/api/system_info_display/display_info_provider.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
 #include "chrome/common/chrome_switches.h"
 
 namespace extensions {
 
 using api::system_info_display::Bounds;
 using api::system_info_display::DisplayUnitInfo;
 
 class MockDisplayInfoProvider : public DisplayInfoProvider {
  public:
   virtual bool QueryInfo(DisplayInfo* info) OVERRIDE {
     info->clear();
     for (int i = 0; i < 2; i++) {

[Greg Spencer (Chromium), 2013/06/10 19:17:42]

Don't you want to go to i < 4 to catch all the rotations and to future proof the
code for when we support more than two displays?

[tbarzic, 2013/06/10 19:53:51]

done, but I don't think that this adds any test coverage (as we get values
directly from a mock).

       linked_ptr<DisplayUnitInfo> unit(new DisplayUnitInfo());
-      unit->id = "DISPLAY";
-      unit->name = "DISPLAY NAME";
+      unit->id = base::IntToString(i);
+      unit->name = "DISPLAY NAME FOR " + unit->id;
+      if (i == 1)
+        unit->mirroring_source_id = "0";
       unit->is_primary = i == 0 ? true : false;
       unit->is_internal = i == 0 ? true : false;
       unit->is_enabled = true;
+      unit->rotation = 90 * i;
       unit->dpi_x = 96.0;
       unit->dpi_y = 96.0;
       unit->bounds.left = 0;
       unit->bounds.top = 0;
       unit->bounds.width = 1280;
       unit->bounds.height = 720;
+      if (i == 0) {
+        unit->visible_area.left = 20;
+        unit->visible_area.top = 40;
+        unit->visible_area.width = 1280;
+        unit->visible_area.height = 720;
+      }
       unit->work_area.left = 0;
       unit->work_area.top = 0;
       unit->work_area.width = 960;
       unit->work_area.height = 720;
       info->push_back(unit);
     }
     return true;
   }
  private:
   virtual ~MockDisplayInfoProvider() {}
@@ skipping 21 matching lines @@
 
 IN_PROC_BROWSER_TEST_F(SystemInfoDisplayApiTest, Display) {
   // The |provider| will be owned by the singleton instance.
   scoped_refptr<MockDisplayInfoProvider> provider =
       new MockDisplayInfoProvider();
   DisplayInfoProvider::InitializeForTesting(provider);
   ASSERT_TRUE(RunPlatformAppTest("systeminfo/display")) << message_;
 }
 
 } // namespace extensions