Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1668683002: fixes #25668, correctly infer generic method override (Closed)

Created:
4 years, 10 months ago by Jennifer Messerly
Modified:
4 years, 10 months ago
Reviewers:
vsm, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #25668, correctly infer generic method override R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/09403720f8ac33f3ccebd9c6db879d76aef4fd52

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -41 lines) Patch
M pkg/analyzer/lib/src/task/strong_mode.dart View 1 7 chunks +48 lines, -41 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
Pretty straightforward fix. Added a couple of test cases for it.
4 years, 10 months ago (2016-02-03 22:30:42 UTC) #2
vsm
lgtm https://codereview.chromium.org/1668683002/diff/1/pkg/analyzer/lib/src/task/strong_mode.dart File pkg/analyzer/lib/src/task/strong_mode.dart (right): https://codereview.chromium.org/1668683002/diff/1/pkg/analyzer/lib/src/task/strong_mode.dart#newcode142 pkg/analyzer/lib/src/task/strong_mode.dart:142: * return types of each of the given ...
4 years, 10 months ago (2016-02-03 23:16:15 UTC) #3
Jennifer Messerly
Thanks! https://codereview.chromium.org/1668683002/diff/1/pkg/analyzer/lib/src/task/strong_mode.dart File pkg/analyzer/lib/src/task/strong_mode.dart (right): https://codereview.chromium.org/1668683002/diff/1/pkg/analyzer/lib/src/task/strong_mode.dart#newcode142 pkg/analyzer/lib/src/task/strong_mode.dart:142: * return types of each of the given ...
4 years, 10 months ago (2016-02-04 18:18:51 UTC) #4
Jennifer Messerly
4 years, 10 months ago (2016-02-04 18:20:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
09403720f8ac33f3ccebd9c6db879d76aef4fd52 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698