build/common.gypi - Issue 1668643002: Disable tcmalloc when building for valgrind

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1668643002: Disable tcmalloc when building for valgrind (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index c6aeca43809393f74624d8a375d680e3dd4eefa7..f4436c91184c6c332988263350214d6f938358da 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -2292,6 +2292,10 @@

# TODO(rnk): Kill off variables that no one else uses and just implement

# them under a build_for_tool== condition.

['build_for_tool=="memcheck" or build_for_tool=="tsan"', {

+ # tcmalloc causes Valgrind failures. Discussion in crrev.com/1642383002.

+ 'use_allocator%': 'none',

# gcc flags

'mac_debug_optimization': '1',

'mac_release_optimization': '1',

« no previous file with comments | « no previous file | no next file » | no next file with comments »