Devtools: Switch JS execution context to match inspected node

third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 367 matching lines @@
         if (!selectedNode && this._lastValidSelectedNode)
             this._selectedPathOnReset = this._lastValidSelectedNode.path();
 
         this._breadcrumbs.setSelectedNode(selectedNode);
 
         WebInspector.context.setFlavor(WebInspector.DOMNode, selectedNode);
 
         if (selectedNode) {
             selectedNode.setAsInspectedNode();
             this._lastValidSelectedNode = selectedNode;
+
+            var executionContexts = selectedNode.target().runtimeModel.executionContexts();
+            for (var context of executionContexts) {
+                var frame = context.target().resourceTreeModel.frameForId(context.frameId);
+                if (context.frameId == selectedNode.frameId() || (!selectedNode.frameId() && !frame.parentFrame))

[pfeldman, 2016/02/06 02:59:05]

- What if there is no frame?
- In most of the cases you would not need the frame, why fetching it?
- Computing frameId() twice in a loop gives MxN complexity twice - you should
compute it once before the loop.
- Every node should have frameId, did not get the parentFrame bit.

[samli, 2016/02/08 03:53:50]

Appears nodes in the top frame don't get a frameId at all. Hence I used the top
frame for those cases. If that's not meant to be the case, where should that get
fixed (looks like root doesn't get the frame id)?

^ is the reason I'm fetching the frame, to figure out if its the top frame.

[pfeldman, 2016/02/11 21:47:34]

nodes don't get frameids, only document nodes do. if the top document does not
have one - it needs to be fixed in the sdk.

[samli, 2016/02/15 00:40:13]

Ok done. PTAL, I'm not sure this is the best way to go about it. I suspect it
was regressed at some point with some top node not being sent across protocol
anymore.

+                    WebInspector.context.setFlavor(WebInspector.ExecutionContext, context);
+            }
         }
         WebInspector.notifications.dispatchEventToListeners(WebInspector.NotificationService.Events.SelectedNodeChanged);
         this._selectedNodeChangedForTest();
     },
 
     _selectedNodeChangedForTest: function() { },
 
     _reset: function()
     {
         delete this.currentQuery;
@@ skipping 877 matching lines @@
      */
     wasShown: function()
     {
         this._toolbarItem.setToggled(true);
         this._nodeChanged();
         WebInspector.ThrottledWidget.prototype.wasShown.call(this);
     },
 
     __proto__: WebInspector.ThrottledWidget.prototype
 }