third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp - Issue 1668553003: Fix server-side image map click location with "Open link in new tab"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

Issue 1668553003: Fix server-side image map click location with "Open link in new tab" Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: appendServerMapMousePosition function made static Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLAnchorElement.h ('k') | third_party/WebKit/Source/core/loader/EmptyClients.h » ('j') | third_party/WebKit/Source/core/page/ContextMenuController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp b/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

index 3dbdcc3b805aec85c27bd3f8d23406510af8f5d2..3e343bc3aa1f9d5d2d7ba6d33ac3bc433735accd 100644

--- a/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

@@ -107,7 +107,7 @@ bool HTMLAnchorElement::isKeyboardFocusable() const

return HTMLElement::isKeyboardFocusable();

}

-static void appendServerMapMousePosition(StringBuilder& url, Event* event)

+void HTMLAnchorElement::appendServerMapMousePosition(StringBuilder& url, Event* event)

JakeYoon 2016/02/05 04:04:49 Could you explain to me the reason that argument s

tkent 2016/02/05 06:00:45 It ensures the Event object is not modified in the

JakeYoon 2016/02/05 07:28:34 Okay I change params type, |*| to |const *|

{

if (!event->isMouseEvent())

return;