Set an exit code when exiting build_sdk_summary in error.

Set an exit code when exiting build_sdk_summary in error.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/24e3e091d63d185394384e5952a0498a7cb7b339

[Paul Berry, 2016-02-03 18:56:25]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-02-03 18:56:57]

LGTM

[kevmoo, 2016-02-03 19:22:07]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2016-02-03 19:22:08]

DBC

https://codereview.chromium.org/1668533002/diff/1/pkg/analyzer/tool/summary/b...
File pkg/analyzer/tool/summary/build_sdk_summary.dart (right):

https://codereview.chromium.org/1668533002/diff/1/pkg/analyzer/tool/summary/b...
pkg/analyzer/tool/summary/build_sdk_summary.dart:15: exit(1);
consider setting exitCode = 1 and return.

exit(n) borks Observatory – so you can't do code coverage, etc.

[Paul Berry, 2016-02-04 13:27:34]

https://codereview.chromium.org/1668533002/diff/1/pkg/analyzer/tool/summary/b...
File pkg/analyzer/tool/summary/build_sdk_summary.dart (right):

https://codereview.chromium.org/1668533002/diff/1/pkg/analyzer/tool/summary/b...
pkg/analyzer/tool/summary/build_sdk_summary.dart:15: exit(1);
On 2016/02/03 19:22:07, kevmoo wrote:
> consider setting exitCode = 1 and return.
> 
> exit(n) borks Observatory – so you can't do code coverage, etc.

Done.

[Paul Berry, 2016-02-04 13:27:47]

Description was changed from

==========
Set an exit code when exiting build_sdk_summary in error.
==========

to

==========
Set an exit code when exiting build_sdk_summary in error.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/24e3e091d63d185394384e5952a0498a7cb7b339
==========

[Paul Berry, 2016-02-04 13:27:50]

Committed patchset #1 (id:1) manually as
24e3e091d63d185394384e5952a0498a7cb7b339 (presubmit successful).