Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: components/password_manager/core/browser/affiliation_utils.cc

Issue 1668523002: [Password Manager] Switch password manager code to use the Feature framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/affiliation_utils.cc
diff --git a/components/password_manager/core/browser/affiliation_utils.cc b/components/password_manager/core/browser/affiliation_utils.cc
index 853edc528923524e8356a6b51775f7a89150eec6..b76d7827d700d410174724abffc0234a683ddc94 100644
--- a/components/password_manager/core/browser/affiliation_utils.cc
+++ b/components/password_manager/core/browser/affiliation_utils.cc
@@ -8,12 +8,9 @@
#include <ostream>
#include "base/base64.h"
-#include "base/command_line.h"
-#include "base/metrics/field_trial.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "components/autofill/core/common/password_form.h"
-#include "components/password_manager/core/common/password_manager_switches.h"
#include "components/url_formatter/elide_url.h"
#include "components/variations/variations_associated_data.h"
#include "net/base/escape.h"
@@ -27,9 +24,6 @@ namespace {
// The scheme used for identifying Android applications.
const char kAndroidAppScheme[] = "android";
-// The name of the field trial controlling affiliation-based matching.
-const char kFieldTrialName[] = "AffiliationBasedMatching";
-
// Returns a StringPiece corresponding to |component| in |uri|, or the empty
// string in case there is no such component.
base::StringPiece ComponentString(const std::string& uri,
@@ -294,35 +288,6 @@ bool AreEquivalenceClassesEqual(const AffiliatedFacets& a,
return std::equal(a_sorted.begin(), a_sorted.end(), b_sorted.begin());
}
-bool IsAffiliationBasedMatchingEnabled(const base::CommandLine& command_line) {
- // Note: It is important to always query the field trial state, to ensure that
- // UMA reports the correct group.
- const std::string group_name =
- base::FieldTrialList::FindFullName(kFieldTrialName);
-
- if (command_line.HasSwitch(switches::kDisableAffiliationBasedMatching))
- return false;
- if (command_line.HasSwitch(switches::kEnableAffiliationBasedMatching))
- return true;
- return !base::StartsWith(group_name, "Disabled",
- base::CompareCase::INSENSITIVE_ASCII);
-}
-
-bool IsPropagatingPasswordChangesToWebCredentialsEnabled(
- const base::CommandLine& command_line) {
- // Note: It is important to always query the variation param first, which, in
- // turn, queries the field trial state, which ensures that UMA reports the
- // correct group if it is forced by a command line flag.
- const std::string update_enabled = variations::GetVariationParamValue(
- kFieldTrialName, "propagate_password_changes_to_web");
-
- if (command_line.HasSwitch(switches::kDisableAffiliationBasedMatching))
- return false;
- if (command_line.HasSwitch(switches::kEnableAffiliationBasedMatching))
- return true;
- return !base::LowerCaseEqualsASCII(update_enabled, "disabled");
-}
-
bool IsValidAndroidFacetURI(const std::string& url) {
FacetURI facet = FacetURI::FromPotentiallyInvalidSpec(url);
return facet.IsValidAndroidFacetURI();

Powered by Google App Engine
This is Rietveld 408576698