Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6773)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1668523002: [Password Manager] Switch password manager code to use the Feature framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes mac bot breakages. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 1bfb08f01263baaf63e003ea135fa3ad3f565161..7429a184b631945f06faea4b813bcd0d32f6efe6 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -46,7 +46,6 @@
#include "components/password_manager/core/common/credential_manager_types.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "components/password_manager/core/common/password_manager_pref_names.h"
-#include "components/password_manager/core/common/password_manager_switches.h"
#include "components/password_manager/sync/browser/password_sync_util.h"
#include "components/prefs/pref_service.h"
#include "components/signin/core/browser/signin_manager.h"
@@ -564,14 +563,15 @@ bool ChromePasswordManagerClient::IsUpdatePasswordUIEnabled() const {
}
bool ChromePasswordManagerClient::EnabledForSyncSignin() {
- base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
- if (command_line->HasSwitch(
- password_manager::switches::kDisableManagerForSyncSignin))
+ if (base::FeatureList::IsEnabled(
+ password_manager::features::kDisableManagerForSyncSignin)) {
return false;
+ }
- if (command_line->HasSwitch(
- password_manager::switches::kEnableManagerForSyncSignin))
+ if (base::FeatureList::IsEnabled(
+ password_manager::features::kEnableManagerForSyncSignin)) {
return true;
+ }
// Default is enabled.
std::string group_name =

Powered by Google App Engine
This is Rietveld 408576698