[Password Manager] Switch password manager code to use the Feature framework.

components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/sync/browser/sync_credentials_filter.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
-#include "base/command_line.h"
 #include "base/macros.h"
 #include "base/test/histogram_tester.h"
 #include "base/test/user_action_tester.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/core/browser/stub_password_manager_client.h"
-#include "components/password_manager/core/common/password_manager_switches.h"
+#include "components/password_manager/core/common/password_manager_features.h"
 #include "components/password_manager/sync/browser/sync_username_test_base.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using autofill::PasswordForm;
 
 namespace password_manager {
 
 namespace {
 
 class FakePasswordManagerClient : public StubPasswordManagerClient {
@@ skipping 12 matching lines @@
   GURL last_committed_entry_url_;
 };
 
 bool IsFormFiltered(const CredentialsFilter* filter, const PasswordForm& form) {
   ScopedVector<PasswordForm> vector;
   vector.push_back(new PasswordForm(form));
   vector = filter->FilterResults(std::move(vector));
   return vector.empty();
 }
 
+void EnableFeature(const base::Feature& feature) {

[vabr (Chromium), 2016/02/08 14:16:49]

optional: Instead of duplicating it here and in the affiliation utils test, you
could consider adding this function to
components/password_manager/core/browser/password_manager_test_utils.*

[Pritam Nikam, 2016/02/08 15:27:19]

Done.

+  // Enable the command-line feature.
+  base::FeatureList::ClearInstanceForTesting();
+  scoped_ptr<base::FeatureList> feature_list(new base::FeatureList);
+  feature_list->InitializeFromCommandLine(feature.name, "");
+  base::FeatureList::SetInstance(std::move(feature_list));
+}
+
 }  // namespace
 
 class CredentialsFilterTest : public SyncUsernameTestBase {
  public:
   struct TestCase {
     enum { SYNCING_PASSWORDS, NOT_SYNCING_PASSWORDS } password_sync;
     PasswordForm form;
     std::string fake_sync_username;
     const char* const last_committed_entry_url;
     enum { FORM_FILTERED, FORM_NOT_FILTERED } is_form_filtered;
@@ skipping 67 matching lines @@
        TestCase::FORM_NOT_FILTERED, TestCase::NO_HISTOGRAM},
   };
 
   for (size_t i = 0; i < arraysize(kTestCases); ++i) {
     SCOPED_TRACE(testing::Message() << "i=" << i);
     CheckFilterResultsTestCase(kTestCases[i]);
   }
 }
 
 TEST_F(CredentialsFilterTest, FilterResults_DisallowSyncOnReauth) {
-  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
-  command_line->AppendSwitch(
-      switches::kDisallowAutofillSyncCredentialForReauth);
+  EnableFeature(features::kDisallowAutofillSyncCredentialForReauth);
 
   const TestCase kTestCases[] = {
       // Reauth URL, not sync username.
       {TestCase::SYNCING_PASSWORDS, SimpleGaiaForm("user@example.org"),
        "another_user@example.org",
        "https://accounts.google.com/login?rart=123&continue=blah",
        TestCase::FORM_NOT_FILTERED, TestCase::HISTOGRAM_REPORTED},
 
       // Reauth URL, sync username.
       {TestCase::SYNCING_PASSWORDS, SimpleGaiaForm("user@example.org"),
@@ skipping 18 matching lines @@
        TestCase::FORM_NOT_FILTERED, TestCase::NO_HISTOGRAM},
   };
 
   for (size_t i = 0; i < arraysize(kTestCases); ++i) {
     SCOPED_TRACE(testing::Message() << "i=" << i);
     CheckFilterResultsTestCase(kTestCases[i]);
   }
 }
 
 TEST_F(CredentialsFilterTest, FilterResults_DisallowSync) {
-  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
-  command_line->AppendSwitch(switches::kDisallowAutofillSyncCredential);
+  EnableFeature(features::kDisallowAutofillSyncCredential);
 
   const TestCase kTestCases[] = {
       // Reauth URL, not sync username.
       {TestCase::SYNCING_PASSWORDS, SimpleGaiaForm("user@example.org"),
        "another_user@example.org",
        "https://accounts.google.com/login?rart=123&continue=blah",
        TestCase::FORM_NOT_FILTERED, TestCase::HISTOGRAM_REPORTED},
 
       // Reauth URL, sync username.
       {TestCase::SYNCING_PASSWORDS, SimpleGaiaForm("user@example.org"),
@@ skipping 51 matching lines @@
 TEST_F(CredentialsFilterTest, ShouldSave_SyncCredential_NotSyncingPasswords) {
   PasswordForm form = SimpleGaiaForm("user@example.org");
 
   FakeSigninAs("user@example.org");
   SetSyncingPasswords(false);
   EXPECT_TRUE(filter()->ShouldSave(form));
 }
 
 TEST_F(CredentialsFilterTest, ShouldFilterOneForm) {
   // Adding disallow switch should cause sync credential to be filtered.
-  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
-  command_line->AppendSwitch(switches::kDisallowAutofillSyncCredential);
+  EnableFeature(features::kDisallowAutofillSyncCredential);
 
   ScopedVector<autofill::PasswordForm> results;
   results.push_back(new PasswordForm(SimpleGaiaForm("test1@gmail.com")));
   results.push_back(new PasswordForm(SimpleGaiaForm("test2@gmail.com")));
 
   FakeSigninAs("test1@gmail.com");
 
   results = filter()->FilterResults(std::move(results));
 
   ASSERT_EQ(1u, results.size());
   EXPECT_EQ(SimpleGaiaForm("test2@gmail.com"), *results[0]);
 }
 
 }  // namespace password_manager