[Password Manager] Switch password manager code to use the Feature framework.

components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/sync/browser/sync_credentials_filter.h"
 
 #include <stddef.h>
 #include <utility>
+#include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
-#include "base/command_line.h"
 #include "base/macros.h"
 #include "base/test/histogram_tester.h"
 #include "base/test/user_action_tester.h"
 #include "components/autofill/core/common/password_form.h"
+#include "components/password_manager/core/browser/password_manager_test_utils.h"
 #include "components/password_manager/core/browser/stub_password_manager_client.h"
-#include "components/password_manager/core/common/password_manager_switches.h"
+#include "components/password_manager/core/common/password_manager_features.h"
 #include "components/password_manager/sync/browser/sync_username_test_base.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using autofill::PasswordForm;
 
 namespace password_manager {
 
 namespace {
 
 class FakePasswordManagerClient : public StubPasswordManagerClient {
@@ skipping 99 matching lines @@
        TestCase::FORM_NOT_FILTERED, TestCase::NO_HISTOGRAM},
   };
 
   for (size_t i = 0; i < arraysize(kTestCases); ++i) {
     SCOPED_TRACE(testing::Message() << "i=" << i);
     CheckFilterResultsTestCase(kTestCases[i]);
   }
 }
 
 TEST_F(CredentialsFilterTest, FilterResults_DisallowSyncOnReauth) {
-  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
-  command_line->AppendSwitch(
-      switches::kDisallowAutofillSyncCredentialForReauth);
+  // Only 'protect-sync-credential-on-reauth' feature is kept enabled, fill the
+  // sync credential everywhere but on reauth.
+  scoped_ptr<base::FeatureList> feature_list(new base::FeatureList);
+  std::vector<const base::Feature*> enabled_features;
+  std::vector<const base::Feature*> disabled_features;
+  disabled_features.push_back(&features::kProtectSyncCredential);
+  enabled_features.push_back(&features::kProtectSyncCredentialOnReauth);
+  SetFeatures(enabled_features, disabled_features, std::move(feature_list));
 
   const TestCase kTestCases[] = {
       // Reauth URL, not sync username.
       {TestCase::SYNCING_PASSWORDS, SimpleGaiaForm("user@example.org"),
        "another_user@example.org",
        "https://accounts.google.com/login?rart=123&continue=blah",
        TestCase::FORM_NOT_FILTERED, TestCase::HISTOGRAM_REPORTED},
 
       // Reauth URL, sync username.
       {TestCase::SYNCING_PASSWORDS, SimpleGaiaForm("user@example.org"),
@@ skipping 18 matching lines @@
        TestCase::FORM_NOT_FILTERED, TestCase::NO_HISTOGRAM},
   };
 
   for (size_t i = 0; i < arraysize(kTestCases); ++i) {
     SCOPED_TRACE(testing::Message() << "i=" << i);
     CheckFilterResultsTestCase(kTestCases[i]);
   }
 }
 
 TEST_F(CredentialsFilterTest, FilterResults_DisallowSync) {
-  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
-  command_line->AppendSwitch(switches::kDisallowAutofillSyncCredential);
+  // Both features are kept enabled, should cause sync credential to be
+  // filtered.
+  scoped_ptr<base::FeatureList> feature_list(new base::FeatureList);
+  std::vector<const base::Feature*> enabled_features;
+  std::vector<const base::Feature*> disabled_features;
+  enabled_features.push_back(&features::kProtectSyncCredential);
+  enabled_features.push_back(&features::kProtectSyncCredentialOnReauth);
+  SetFeatures(enabled_features, disabled_features, std::move(feature_list));
 
   const TestCase kTestCases[] = {
       // Reauth URL, not sync username.
       {TestCase::SYNCING_PASSWORDS, SimpleGaiaForm("user@example.org"),
        "another_user@example.org",
        "https://accounts.google.com/login?rart=123&continue=blah",
        TestCase::FORM_NOT_FILTERED, TestCase::HISTOGRAM_REPORTED},
 
       // Reauth URL, sync username.
       {TestCase::SYNCING_PASSWORDS, SimpleGaiaForm("user@example.org"),
@@ skipping 50 matching lines @@
 
 TEST_F(CredentialsFilterTest, ShouldSave_SyncCredential_NotSyncingPasswords) {
   PasswordForm form = SimpleGaiaForm("user@example.org");
 
   FakeSigninAs("user@example.org");
   SetSyncingPasswords(false);
   EXPECT_TRUE(filter()->ShouldSave(form));
 }
 
 TEST_F(CredentialsFilterTest, ShouldFilterOneForm) {
-  // Adding disallow switch should cause sync credential to be filtered.
-  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
-  command_line->AppendSwitch(switches::kDisallowAutofillSyncCredential);
+  // Both features are kept enabled, should cause sync credential to be
+  // filtered.
+  scoped_ptr<base::FeatureList> feature_list(new base::FeatureList);
+  std::vector<const base::Feature*> enabled_features;
+  std::vector<const base::Feature*> disabled_features;
+  enabled_features.push_back(&features::kProtectSyncCredential);
+  enabled_features.push_back(&features::kProtectSyncCredentialOnReauth);
+  SetFeatures(enabled_features, disabled_features, std::move(feature_list));
 
   ScopedVector<autofill::PasswordForm> results;
   results.push_back(new PasswordForm(SimpleGaiaForm("test1@gmail.com")));
   results.push_back(new PasswordForm(SimpleGaiaForm("test2@gmail.com")));
 
   FakeSigninAs("test1@gmail.com");
 
   results = filter()->FilterResults(std::move(results));
 
   ASSERT_EQ(1u, results.size());
   EXPECT_EQ(SimpleGaiaForm("test2@gmail.com"), *results[0]);
 }
 
 }  // namespace password_manager