[Password Manager] Switch password manager code to use the Feature framework.

chrome/browser/password_manager/chrome_password_manager_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 28 matching lines @@
 #include "components/password_manager/core/browser/log_receiver.h"
 #include "components/password_manager/core/browser/password_bubble_experiment.h"
 #include "components/password_manager/core/browser/password_form_manager.h"
 #include "components/password_manager/core/browser/password_manager_internals_service.h"
 #include "components/password_manager/core/browser/password_manager_metrics_util.h"
 #include "components/password_manager/core/browser/password_manager_settings_migration_experiment.h"
 #include "components/password_manager/core/browser/password_manager_util.h"
 #include "components/password_manager/core/common/credential_manager_types.h"
 #include "components/password_manager/core/common/password_manager_features.h"
 #include "components/password_manager/core/common/password_manager_pref_names.h"
-#include "components/password_manager/core/common/password_manager_switches.h"
 #include "components/password_manager/sync/browser/password_sync_util.h"
 #include "components/prefs/pref_service.h"
 #include "components/signin/core/browser/signin_manager.h"
 #include "components/version_info/version_info.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "google_apis/gaia/gaia_urls.h"
 #include "net/base/url_util.h"
 #include "third_party/re2/src/re2/re2.h"
@@ skipping 505 matching lines @@
   return true;
 #endif
 }
 
 bool ChromePasswordManagerClient::IsUpdatePasswordUIEnabled() const {
   // Currently Password update UI is implemented only for Bubble UI.
   return IsTheHotNewBubbleUIEnabled();
 }
 
 bool ChromePasswordManagerClient::EnabledForSyncSignin() {
-  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
-  if (command_line->HasSwitch(
-          password_manager::switches::kDisableManagerForSyncSignin))
+  if (password_manager_util::IsFeatureDisabledFromCommandLine(
+          password_manager::features::kManagerForSyncSignin)) {

[Bernhard Bauer, 2016/02/11 11:12:40]

I don't think this is necessary; FeatureList will take care of that.

(This also applies to all the other calls to this method in this CL, so the
whole method can be removed.)

[Pritam Nikam, 2016/02/25 14:16:06]

Done.

     return false;
+  }
 
-  if (command_line->HasSwitch(
-          password_manager::switches::kEnableManagerForSyncSignin))
+  if (base::FeatureList::IsEnabled(
+          password_manager::features::kManagerForSyncSignin)) {
     return true;
+  }
 
   // Default is enabled.
   std::string group_name =
       base::FieldTrialList::FindFullName("PasswordManagerStateForSyncSignin");
   return group_name != "Disabled";
 }
 
 const GURL& ChromePasswordManagerClient::GetMainFrameURL() const {
   return web_contents()->GetVisibleURL();
 }
@@ skipping 10 matching lines @@
 
 const password_manager::CredentialsFilter*
 ChromePasswordManagerClient::GetStoreResultFilter() const {
   return &credentials_filter_;
 }
 
 const password_manager::LogManager* ChromePasswordManagerClient::GetLogManager()
     const {
   return log_manager_.get();
 }