Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Issue 1668463006: x87: fixed x87 stack state in TurboFan (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

x87: fixed x87 stack state in TurboFan Unstructured control flow caused by excpetion handling leads to a wrong x87 stack state. This patch is to reset the x87 state at the hanlder entry point. Thanks for help from weiliang.lin@intel.com. BUG= Committed: https://crrev.com/ce16b44be3448e43f916e229ad1e20a0b273f4ed Cr-Commit-Position: refs/heads/master@{#33738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -15 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 4 chunks +28 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-04 14:24:17 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-04 14:25:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668463006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668463006/1
4 years, 10 months ago (2016-02-04 14:32:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 14:57:28 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 14:57:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce16b44be3448e43f916e229ad1e20a0b273f4ed
Cr-Commit-Position: refs/heads/master@{#33738}

Powered by Google App Engine
This is Rietveld 408576698