third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 1668453002: Make empty selection behavior behave like Android EditText.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 1668453002: Make empty selection behavior behave like Android EditText. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Apply code review and fix test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/SelectionController.cpp ('k') | third_party/WebKit/Source/web/tests/data/longpress_textarea.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index e91eee8f9885e38fb5e7234c829d9f463453fbdb..46ce4ec0984266fb84cb538dd7c061fdd2fa5e92 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -1617,6 +1617,22 @@ TEST_F(WebViewTest, LongPressSelection)

EXPECT_EQ("testword", std::string(frame->selectionAsText().utf8().data()));

}

+TEST_F(WebViewTest, LongPressEmptyTextarea)

+ URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("longpress_textarea.html"));

+ WebView* webView = m_webViewHelper.initializeAndLoad(m_baseURL + "longpress_textarea.html", true);

+ webView->resize(WebSize(500, 300));

+ webView->updateAllLifecyclePhases();

+ runPendingTasks();

+ WebString blanklinestextbox = WebString::fromUTF8("blanklinestextbox");

+ WebLocalFrameImpl* frame = toWebLocalFrameImpl(webView->mainFrame());

+ EXPECT_TRUE(tapElementById(webView, WebInputEvent::GestureLongPress, blanklinestextbox));

+ EXPECT_EQ("", std::string(frame->selectionAsText().utf8().data()));

TEST_F(WebViewTest, BlinkCaretOnTypingAfterLongPress)

{

URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("blink_caret_on_typing_after_long_press.html"));