content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 1668453002: Make empty selection behavior behave like Android EditText.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 1668453002: Make empty selection behavior behave like Android EditText. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile error in WebViewTest Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/SelectionController.cpp » ('j') | third_party/WebKit/Source/core/editing/SelectionController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index caa1c48185b691f743e5a067f123be5e2555064c..e6eb23a536823ecf8c691e22078af60c14dc27e6 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1250,6 +1250,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen

mGestureStateListenersIterator.hasNext();) {

mGestureStateListenersIterator.next().onSingleTap(consumed, x, y);

}

+ hidePastePopup();

}

@SuppressWarnings("unused")

@@ -2241,6 +2242,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen

} else {

showPastePopup(xAnchor, yAnchor);

}

+ mWasPastePopupShowingOnInsertionDragStart = false;

break;

case SelectionEventType.INSERTION_HANDLE_CLEARED:

@@ -2255,6 +2257,11 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen

break;

case SelectionEventType.INSERTION_HANDLE_DRAG_STOPPED:

+ if (mWasPastePopupShowingOnInsertionDragStart) {

+ showPastePopup(xAnchor, yAnchor);

+ }

+ mWasPastePopupShowingOnInsertionDragStart = false;

+ break;

case SelectionEventType.SELECTION_ESTABLISHED:

case SelectionEventType.SELECTION_DISSOLVED:

break;