Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1668413003: Remove logging of unused and deprecated PeerConnection::Observer callbacks (Closed)

Created:
4 years, 10 months ago by perkj_chrome
Modified:
4 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove logging of unused and deprecated PeerConnection::Observer callbacks This removes loggin in OnStateChanged() OnIceComplete() The methods will be deleted from the interface and has been deprecated for a long time. Committed: https://crrev.com/a124b9b1239a9e5ce0da2ce007ebc726415f8538 Cr-Commit-Position: refs/heads/master@{#374109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M remoting/host/cast_extension_session.h View 2 chunks +0 lines, -3 lines 0 comments Download
M remoting/host/cast_extension_session.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
perkj_chrome
Please?
4 years, 10 months ago (2016-02-05 11:11:08 UTC) #2
Sergey Ulanov
lgtm
4 years, 10 months ago (2016-02-05 20:33:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668413003/1
4 years, 10 months ago (2016-02-08 08:05:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 12:05:52 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 12:07:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a124b9b1239a9e5ce0da2ce007ebc726415f8538
Cr-Commit-Position: refs/heads/master@{#374109}

Powered by Google App Engine
This is Rietveld 408576698