Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 1668373002: Canvas captureStream() to capture a frame in the start (Closed)

Created:
4 years, 10 months ago by emircan
Modified:
4 years, 10 months ago
Reviewers:
mcasas
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Canvas captureStream() to capture a frame in the start W3C spec states that "the captured stream always captures at least one frame, even if frameRate is zero." [0] This CL satisfies this constraint by adding a capture frame call during the initialization. [0] https://www.w3.org/TR/mediacapture-fromelement/#html-canvas-element-media-capture-extensions BUG=524218 Committed: https://crrev.com/9909694b493e872de66cc26be9c510c249a6de5b Cr-Commit-Position: refs/heads/master@{#373737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/TimedCanvasDrawListener.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
emircan
PTAL.
4 years, 10 months ago (2016-02-04 23:41:18 UTC) #3
mcasas
LGTM
4 years, 10 months ago (2016-02-05 02:01:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668373002/1
4 years, 10 months ago (2016-02-05 03:18:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 03:23:57 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 03:25:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9909694b493e872de66cc26be9c510c249a6de5b
Cr-Commit-Position: refs/heads/master@{#373737}

Powered by Google App Engine
This is Rietveld 408576698