Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: chrome/browser/extensions/api/app_window/app_window_api.cc

Issue 166833004: Add support for chrome.app.window.create() to app_shell (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase (shell_app_window) Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/app_window/app_window_api.cc
diff --git a/chrome/browser/extensions/api/app_window/app_window_api.cc b/chrome/browser/extensions/api/app_window/app_window_api.cc
index 658e085ca8440654eff9c6900b777ca52fbc52bb..66eeb94fcf682a4477dfdd769d5c6adb31754518 100644
--- a/chrome/browser/extensions/api/app_window/app_window_api.cc
+++ b/chrome/browser/extensions/api/app_window/app_window_api.cc
@@ -7,6 +7,7 @@
#include "apps/app_window.h"
#include "apps/app_window_contents.h"
#include "apps/app_window_registry.h"
+#include "apps/apps_client.h"
#include "apps/ui/native_app_window.h"
#include "base/command_line.h"
#include "base/strings/string_number_conversions.h"
@@ -17,7 +18,6 @@
#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
#include "chrome/browser/extensions/window_controller.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/apps/chrome_app_window_delegate.h"
#include "chrome/common/extensions/api/app_window.h"
#include "chrome/common/extensions/features/feature_channel.h"
#include "content/public/browser/notification_registrar.h"
@@ -269,8 +269,8 @@ bool AppWindowCreateFunction::RunImpl() {
create_params.creator_process_id =
render_view_host_->GetProcess()->GetID();
- AppWindow* app_window = new AppWindow(
- GetProfile(), new ChromeAppWindowDelegate(), GetExtension());
+ AppWindow* app_window =
+ apps::AppsClient::Get()->CreateAppWindow(GetProfile(), GetExtension());
app_window->Init(
url, new apps::AppWindowContentsImpl(app_window), create_params);

Powered by Google App Engine
This is Rietveld 408576698