Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

Issue 1668283002: Set empty icon to alert dialogs on mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: No memory leakz Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
index fa6d65f95eb8f30e4324317d593a1f0a81d7f58b..51f96a0da3fc25cf35ab3df7b303203e179243ed 100644
--- a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
+++ b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
@@ -81,8 +81,13 @@ const int kMessageTextMaxSlots = 2000;
}
- (NSAlert*)alert {
- if (!alert_)
+ if (!alert_) {
alert_.reset([[NSAlert alloc] init]);
+ // Set a blank icon.
+ NSImage* image =
+ [[[NSImage alloc] initWithSize:NSMakeSize(1, 1)] autorelease];
+ [alert_ setIcon:image];
+ }
return alert_;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698