Refactor bluetooth_task_manager_win to prepare for new Bluetooth test fixture

Refactor bluetooth_task_manager_win to prepare for new Bluetooth test fixture

This CL refactors bluetooth_task_manager_win to prepare for simulating fake Bluetooth
classic device for the new Bluetooth test fixture.

BUG=579202
Committed: https://crrev.com/b8c706a00e9cbb83127a0034353289eb6b67d7ef
Cr-Commit-Position: refs/heads/master@{#373699}

[gogerald1, 2016-02-04 22:02:53]

Description was changed from

==========
refactor

BUG=
==========

to

==========
Refactor bluetooth_task_manager_win to prepare for new Bluetooth test fixture

This CL refactors bluetooth_task_manager_win to prepare for simulating fake
Bluetooth 
classic device for the new Bluetooth test fixture.

BUG=579202
==========

[gogerald1, 2016-02-04 22:05:03]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-04 22:07:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1668233004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1668233004/1

[gogerald1, 2016-02-04 22:07:53]

gogerald@chromium.org changed reviewers:
+ scheib@chromium.org

[gogerald1, 2016-02-04 22:07:53]

Hi Vincent, PTAL.

[ortuno, 2016-02-04 22:17:52]

ortuno@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2016-02-04 22:17:53]

https://codereview.chromium.org/1668233004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_task_manager_win.cc (right):

https://codereview.chromium.org/1668233004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_task_manager_win.cc:89:
device::win::BluetoothClassicWrapper::GetInstance()->BTGetRadioInfo(
I don't think you need the BT. You already say BluetoothClassic every time you
want to call the wrappers functions.

[gogerald1, 2016-02-04 22:34:18]

Patchset #2 (id:20001) has been deleted

[gogerald1, 2016-02-04 22:40:39]

Patchset #2 (id:40001) has been deleted

[gogerald1, 2016-02-04 22:41:46]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[gogerald1, 2016-02-04 22:42:00]

https://codereview.chromium.org/1668233004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_task_manager_win.cc (right):

https://codereview.chromium.org/1668233004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_task_manager_win.cc:89:
device::win::BluetoothClassicWrapper::GetInstance()->BTGetRadioInfo(
On 2016/02/04 22:17:53, ortuno wrote:
> I don't think you need the BT. You already say BluetoothClassic every time you
> want to call the wrappers functions.

Done.

[commit-bot: I haz the power, 2016-02-04 22:46:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1668233004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1668233004/60001

[scheib, 2016-02-04 23:36:39]

LGTM with one fix:

https://codereview.chromium.org/1668233004/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_classic_win.cc (right):

https://codereview.chromium.org/1668233004/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win.cc:10: static BluetoothClassicWrapper*
instance_ = nullptr;
use g_ prefix on the global. 

Place the global into an anonymous namespace.
https://www.chromium.org/developers/coding-style#TOC-Unnamed-Namespaces

Move to top of .cc file -- we expect statics and globals at top.

I should have made these comments in
https://codereview.chromium.org/1646023002#msg10 sorry, but please fix up
bluetooth_low_energy_win.cc also.

[gogerald1, 2016-02-04 23:48:59]

https://codereview.chromium.org/1668233004/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_classic_win.cc (right):

https://codereview.chromium.org/1668233004/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win.cc:10: static BluetoothClassicWrapper*
instance_ = nullptr;
On 2016/02/04 23:36:39, scheib wrote:
> use g_ prefix on the global. 
> 
> Place the global into an anonymous namespace.
> https://www.chromium.org/developers/coding-style#TOC-Unnamed-Namespaces
> 
> Move to top of .cc file -- we expect statics and globals at top.
> 
> I should have made these comments in
> https://codereview.chromium.org/1646023002#msg10 sorry, but please fix up
> bluetooth_low_energy_win.cc also.

Done.

[gogerald1, 2016-02-04 23:49:02]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2016-02-04 23:49:03]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1668233004/#ps80001
(title: "address comments")

[commit-bot: I haz the power, 2016-02-04 23:50:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1668233004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1668233004/80001

[commit-bot: I haz the power, 2016-02-05 01:07:43]

Description was changed from

==========
Refactor bluetooth_task_manager_win to prepare for new Bluetooth test fixture

This CL refactors bluetooth_task_manager_win to prepare for simulating fake
Bluetooth 
classic device for the new Bluetooth test fixture.

BUG=579202
==========

to

==========
Refactor bluetooth_task_manager_win to prepare for new Bluetooth test fixture

This CL refactors bluetooth_task_manager_win to prepare for simulating fake
Bluetooth 
classic device for the new Bluetooth test fixture.

BUG=579202
==========

[commit-bot: I haz the power, 2016-02-05 01:07:44]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-02-05 01:08:36]

Description was changed from

==========
Refactor bluetooth_task_manager_win to prepare for new Bluetooth test fixture

This CL refactors bluetooth_task_manager_win to prepare for simulating fake
Bluetooth 
classic device for the new Bluetooth test fixture.

BUG=579202
==========

to

==========
Refactor bluetooth_task_manager_win to prepare for new Bluetooth test fixture

This CL refactors bluetooth_task_manager_win to prepare for simulating fake
Bluetooth
classic device for the new Bluetooth test fixture.

BUG=579202

Committed: https://crrev.com/b8c706a00e9cbb83127a0034353289eb6b67d7ef
Cr-Commit-Position: refs/heads/master@{#373699}
==========

[commit-bot: I haz the power, 2016-02-05 01:08:37]

Patchset 3 (id:??) landed as
https://crrev.com/b8c706a00e9cbb83127a0034353289eb6b67d7ef
Cr-Commit-Position: refs/heads/master@{#373699}