Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1668143002: MIPS: Fix FPU min, max, mina, maxa in simulator. (Closed)

Created:
4 years, 10 months ago by balazs.kilvady
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix FPU min, max, mina, maxa in simulator. BUG= TEST=cctest/test-assembler-mips/min_max, cctest/test-assembler-mips/mina_maxa, cctest/test-assembler-mips64/min_max, cctest/test-assembler-mips64/mina_maxa Committed: https://crrev.com/a58c750ccc17b0f6f1201c3aa177c60487248c24 Cr-Commit-Position: refs/heads/master@{#33790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -322 lines) Patch
M src/mips/simulator-mips.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/mips/simulator-mips.cc View 3 chunks +94 lines, -116 lines 0 comments Download
M src/mips64/simulator-mips64.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 3 chunks +89 lines, -112 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 4 chunks +58 lines, -47 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 4 chunks +58 lines, -47 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668143002/1
4 years, 10 months ago (2016-02-04 13:55:16 UTC) #2
balazs.kilvady
4 years, 10 months ago (2016-02-04 13:57:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 14:33:32 UTC) #6
akos.palfi.imgtec
lgtm
4 years, 10 months ago (2016-02-05 12:27:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668143002/1
4 years, 10 months ago (2016-02-05 17:43:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 17:58:27 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 17:59:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a58c750ccc17b0f6f1201c3aa177c60487248c24
Cr-Commit-Position: refs/heads/master@{#33790}

Powered by Google App Engine
This is Rietveld 408576698