Make DeclarationResolver re-associate Annotations with ElementAnnotations.

Make DeclarationResolver re-associate Annotations with ElementAnnotations.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/2cdec8fd1051d8207bc4135fd04928a2e6a27a98

[Paul Berry, 2016-02-04 19:31:37]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-02-04 19:44:52]

LGTM

https://codereview.chromium.org/1667963005/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1667963005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:2406:
_resolveMetadata(node.metadata, compilationUnitElement.metadata);
Do we want to do this here? I think the compilation unit element is the one
associated with the part. Won't we end up with a similar problem as 'part of'
directives if we have parts being included in multiple libraries?

[Paul Berry, 2016-02-04 20:17:42]

https://codereview.chromium.org/1667963005/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1667963005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:2406:
_resolveMetadata(node.metadata, compilationUnitElement.metadata);
On 2016/02/04 19:44:52, Brian Wilkerson wrote:
> Do we want to do this here? I think the compilation unit element is the one
> associated with the part. Won't we end up with a similar problem as 'part of'
> directives if we have parts being included in multiple libraries?

I don't think it will be a problem, because if a single part file is included in
N libraries, N separate CompilationUnitElements are created, one for each
library.

[Paul Berry, 2016-02-04 20:45:14]

Whoops, I forgot to run tests before submitting for review.  It turns out that I
wasn't handling some cases where the element model could contain nulls.

PTAL (most of the changes are in patch set 2).

[Brian Wilkerson, 2016-02-04 21:31:06]

LGTM

[Paul Berry, 2016-02-04 22:09:17]

Description was changed from

==========
Make DeclarationResolver re-associate Annotations with ElementAnnotations.
==========

to

==========
Make DeclarationResolver re-associate Annotations with ElementAnnotations.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2cdec8fd1051d8207bc4135fd04928a2e6a27a98
==========

[Paul Berry, 2016-02-04 22:09:18]

Committed patchset #4 (id:60001) manually as
2cdec8fd1051d8207bc4135fd04928a2e6a27a98 (presubmit successful).