Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1667953005: Last bit of GrGLSLFragmentProcessor-derived class cleanup (Closed)

Created:
4 years, 10 months ago by robertphillips
Modified:
4 years, 10 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Last bit of GrGLSLFragmentProcessor-derived class cleanup I believe these are the last two that used the dispreferred constructor pattern. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1667953005 Committed: https://skia.googlesource.com/skia/+/d3b32bf8322877cf263229735aef4f04df5415c4

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : more clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -52 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 11 chunks +13 lines, -24 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 2 11 chunks +15 lines, -28 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
robertphillips
4 years, 10 months ago (2016-02-04 18:58:55 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667953005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667953005/40001
4 years, 10 months ago (2016-02-04 18:59:14 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 19:29:52 UTC) #8
robertphillips
ping
4 years, 10 months ago (2016-02-05 12:58:13 UTC) #9
egdaniel
lgtm
4 years, 10 months ago (2016-02-05 14:06:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667953005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667953005/40001
4 years, 10 months ago (2016-02-05 15:12:34 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 15:15:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d3b32bf8322877cf263229735aef4f04df5415c4

Powered by Google App Engine
This is Rietveld 408576698