Issue 1667873002: Merge to XFA: Complete unit tests for CPDF_Array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1667873002: Merge to XFA: Complete unit tests for CPDF_Array (Closed)

Created:
4 years, 10 months ago by Wei Li

Modified:
4 years, 10 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Complete unit tests for CPDF_Array Also remove one unnecessary member function. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1660523003 . (cherry picked from commit 6f358daa2e8b1639a1c3a3f07a449f8450197e8b) Committed: https://pdfium.googlesource.com/pdfium/+/bb53a5dacba0cd7e1a2108d5efbce9b692e5cb5d

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+436 lines, -46 lines)			Patch
M	core/include/fpdfapi/fpdf_objects.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_objects_unittest.cpp	View	11 chunks	+432 lines, -41 lines	0 comments	Download

Total messages: 4 (1 generated)

Wei Li

Committed patchset #1 (id:1) manually as bb53a5dacba0cd7e1a2108d5efbce9b692e5cb5d (presubmit successful).

4 years, 10 months ago (2016-02-03 18:04:25 UTC) #3

Message was sent while issue was closed.

lgtm