Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1667853004: Ignore more files and directories (Closed)

Created:
4 years, 10 months ago by brucedawson
Modified:
4 years, 10 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, Sébastien Marchand
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ignore more files and directories The vs_files directory is used for VS 2015 builds and needs to be in .gitignore, along with vs2013_files. The naming convention for timestamps is changed and .gitignore needs to be updated for that. Finally, the .pylint.d directory keeps being created and should be ignored. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M .gitignore View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
brucedawson
The .timestamps change was introduced by sebmarchand's recent change, the other directories I'm ignoring have ...
4 years, 10 months ago (2016-02-03 22:46:00 UTC) #2
Sébastien Marchand
Thanks ! LGTM for the toolchain related files.
4 years, 10 months ago (2016-02-03 23:37:53 UTC) #4
Sébastien Marchand
rogerta@ : ping ?
4 years, 10 months ago (2016-02-09 15:14:01 UTC) #5
brucedawson
Brad, can you take a look? Just a .ignore update.
4 years, 10 months ago (2016-02-09 20:48:30 UTC) #8
bradnelson
lgtm
4 years, 10 months ago (2016-02-09 21:48:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667853004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667853004/1
4 years, 10 months ago (2016-02-09 21:48:26 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 21:50:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298682

Powered by Google App Engine
This is Rietveld 408576698