third_party/WebKit/Source/core/loader/ImageLoader.h - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/ImageLoader.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp ('k') | third_party/WebKit/Source/core/loader/ImageLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/ImageLoader.h

diff --git a/third_party/WebKit/Source/core/loader/ImageLoader.h b/third_party/WebKit/Source/core/loader/ImageLoader.h

index ec8c8a9edccec13e782b8b33a316ef8bf59c2d40..fd3ca94b90eb1b7caa42b8a7ad9a101964d558ca 100644

--- a/third_party/WebKit/Source/core/loader/ImageLoader.h

+++ b/third_party/WebKit/Source/core/loader/ImageLoader.h

@@ -26,7 +26,6 @@

#include "core/CoreExport.h"

#include "core/fetch/ImageResource.h"

#include "core/fetch/ImageResourceClient.h"

-#include "core/fetch/ResourcePtr.h"

#include "platform/heap/Handle.h"

#include "wtf/HashSet.h"

#include "wtf/WeakPtr.h"

@@ -169,7 +168,7 @@ private:

#endif

RawPtrWillBeMember<Element> m_element;

- ResourcePtr<ImageResource> m_image;

+ RefPtrWillBeMember<ImageResource> m_image;

// FIXME: Oilpan: We might be able to remove this Persistent hack when

// ImageResourceClient is traceable.

GC_PLUGIN_IGNORE("http://crbug.com/383741")