Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + address review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
index 7907c2e936d3c8e4eb51d06a5b43d95d30844f24..b46bc61ccf5d384e6e6524e25acc6771c22b0681 100644
--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
@@ -153,22 +153,20 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv
// this re-implementation of ResourceOwner.
RawResource* resource() const { return m_resource.get(); }
void clearResource() { setResource(nullptr); }
- void setResource(const ResourcePtr<RawResource>& newResource)
+ void setResource(const PassRefPtrWillBeRawPtr<RawResource>& newResource)
{
if (newResource == m_resource)
return;
- if (ResourcePtr<RawResource> oldResource = m_resource) {
- m_resource.clear();
+ if (PassRefPtrWillBeRawPtr<RawResource> oldResource = m_resource.release())
oldResource->removeClient(this);
- }
if (newResource) {
m_resource = newResource;
m_resource->addClient(this);
}
}
- ResourcePtr<RawResource> m_resource;
+ RefPtrWillBePersistent<RawResource> m_resource;
// End of ResourceOwner re-implementation, see above.
SecurityOrigin* securityOrigin() const;

Powered by Google App Engine
This is Rietveld 408576698