third_party/WebKit/Source/core/loader/DocumentLoader.h - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/DocumentLoader.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp ('k') | third_party/WebKit/Source/core/loader/DocumentLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/DocumentLoader.h

diff --git a/third_party/WebKit/Source/core/loader/DocumentLoader.h b/third_party/WebKit/Source/core/loader/DocumentLoader.h

index 7d1f4820f3ee6d0cf248f8ddc9921e54ba323169..f13f8d9266992d74a72e3342ebac2c18f565b334 100644

--- a/third_party/WebKit/Source/core/loader/DocumentLoader.h

+++ b/third_party/WebKit/Source/core/loader/DocumentLoader.h

@@ -35,7 +35,6 @@

#include "core/fetch/ClientHintsPreferences.h"

#include "core/fetch/RawResource.h"

#include "core/fetch/ResourceLoaderOptions.h"

-#include "core/fetch/ResourcePtr.h"

#include "core/fetch/SubstituteData.h"

#include "core/frame/csp/ContentSecurityPolicy.h"

#include "core/loader/DocumentLoadTiming.h"

@@ -144,7 +143,7 @@ public:

bool loadingMultipartContent() const;

- ResourcePtr<Resource> startPreload(Resource::Type, FetchRequest&);

+ Resource* startPreload(Resource::Type, FetchRequest&);

DECLARE_VIRTUAL_TRACE();

@@ -189,7 +188,7 @@ private:

RawPtrWillBeMember<LocalFrame> m_frame;

PersistentWillBeMember<ResourceFetcher> m_fetcher;

- ResourcePtr<RawResource> m_mainResource;

+ RefPtrWillBeMember<RawResource> m_mainResource;

RefPtrWillBeMember<DocumentWriter> m_writer;